-
Notifications
You must be signed in to change notification settings - Fork 4.7k
/
Copy pathdeployments.go
1121 lines (948 loc) · 49.1 KB
/
deployments.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
package deployments
import (
//"errors"
"fmt"
"math/rand"
"strings"
"time"
g "github.com/onsi/ginkgo"
o "github.com/onsi/gomega"
kerrors "k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/types"
"k8s.io/apimachinery/pkg/util/wait"
"k8s.io/apimachinery/pkg/watch"
kapiv1 "k8s.io/kubernetes/pkg/api/v1"
kcontroller "k8s.io/kubernetes/pkg/controller"
e2e "k8s.io/kubernetes/test/e2e/framework"
"github.com/openshift/origin/pkg/client"
deployapi "github.com/openshift/origin/pkg/deploy/apis/apps"
deployutil "github.com/openshift/origin/pkg/deploy/util"
imageapi "github.com/openshift/origin/pkg/image/apis/image"
exutil "github.com/openshift/origin/test/extended/util"
)
const deploymentRunTimeout = 5 * time.Minute
const deploymentChangeTimeout = 30 * time.Second
var _ = g.Describe("deploymentconfigs", func() {
defer g.GinkgoRecover()
var (
oc = exutil.NewCLI("cli-deployment", exutil.KubeConfigPath())
deploymentFixture = exutil.FixturePath("testdata", "deployments", "test-deployment-test.yaml")
simpleDeploymentFixture = exutil.FixturePath("testdata", "deployments", "deployment-simple.yaml")
customDeploymentFixture = exutil.FixturePath("testdata", "deployments", "custom-deployment.yaml")
generationFixture = exutil.FixturePath("testdata", "deployments", "generation-test.yaml")
pausedDeploymentFixture = exutil.FixturePath("testdata", "deployments", "paused-deployment.yaml")
failedHookFixture = exutil.FixturePath("testdata", "deployments", "failing-pre-hook.yaml")
brokenDeploymentFixture = exutil.FixturePath("testdata", "deployments", "test-deployment-broken.yaml")
historyLimitedDeploymentFixture = exutil.FixturePath("testdata", "deployments", "deployment-history-limit.yaml")
minReadySecondsFixture = exutil.FixturePath("testdata", "deployments", "deployment-min-ready-seconds.yaml")
multipleICTFixture = exutil.FixturePath("testdata", "deployments", "deployment-example.yaml")
resolutionFixture = exutil.FixturePath("testdata", "deployments", "deployment-image-resolution.yaml")
anotherMultiICTFixture = exutil.FixturePath("testdata", "deployments", "multi-ict-deployment.yaml")
tagImagesFixture = exutil.FixturePath("testdata", "deployments", "tag-images-deployment.yaml")
readinessFixture = exutil.FixturePath("testdata", "deployments", "readiness-test.yaml")
envRefDeploymentFixture = exutil.FixturePath("testdata", "deployments", "deployment-with-ref-env.yaml")
ignoresDeployersFixture = exutil.FixturePath("testdata", "deployments", "deployment-ignores-deployer.yaml")
imageChangeTriggerFixture = exutil.FixturePath("testdata", "deployments", "deployment-trigger.yaml")
)
g.Describe("when run iteratively [Conformance]", func() {
g.AfterEach(func() {
failureTrap(oc, "deployment-simple", g.CurrentGinkgoTestDescription().Failed)
})
g.It("should only deploy the last deployment", func() {
_, err := oc.Run("create").Args("-f", simpleDeploymentFixture).Output()
o.Expect(err).NotTo(o.HaveOccurred())
iterations := 15
for i := 0; i < iterations; i++ {
if rand.Float32() < 0.2 {
time.Sleep(time.Duration(rand.Float32() * rand.Float32() * float32(time.Second)))
}
switch n := rand.Float32(); {
case n < 0.4:
// trigger a new deployment
e2e.Logf("%02d: triggering a new deployment with config change", i)
out, err := oc.Run("set", "env").Args("dc/deployment-simple", fmt.Sprintf("A=%d", i)).Output()
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(out).To(o.ContainSubstring("updated"))
case n < 0.7:
// cancel any running deployment
e2e.Logf("%02d: cancelling deployment", i)
if out, err := oc.Run("rollout").Args("cancel", "dc/deployment-simple").Output(); err != nil {
// TODO: we should fix this
if !strings.Contains(out, "the object has been modified") {
o.Expect(err).NotTo(o.HaveOccurred())
}
e2e.Logf("rollout cancel deployment failed due to conflict: %v", err)
}
case n < 0.0:
// delete the deployer pod - disabled because it forces the system to wait for the sync loop
e2e.Logf("%02d: deleting one or more deployer pods", i)
_, rcs, pods, err := deploymentInfo(oc, "deployment-simple")
if err != nil {
e2e.Logf("%02d: unable to get deployment info: %v", i, err)
continue
}
all, err := deploymentPods(pods)
if err != nil {
e2e.Logf("%02d: unable to get deployment pods: %v", i, err)
continue
}
if len(all) == 0 {
e2e.Logf("%02d: no deployer pods", i)
continue
}
top := len(rcs) - 1
for j := top; i >= top-1 && j >= 0; j-- {
pods, ok := all[rcs[j].Name]
if !ok {
e2e.Logf("%02d: no deployer pod for rc %q", i, rcs[j].Name)
continue
}
for _, pod := range pods {
e2e.Logf("%02d: deleting deployer pod %s", i, pod.Name)
options := metav1.NewDeleteOptions(0)
if rand.Float32() < 0.5 {
options = nil
}
if err := oc.KubeClient().CoreV1().Pods(oc.Namespace()).Delete(pod.Name, options); err != nil {
e2e.Logf("%02d: unable to delete deployer pod %q: %v", i, pod.Name, err)
}
}
}
e2e.Logf("%02d: triggering a new deployment with config change", i)
out, err := oc.Run("set", "env").Args("dc/deployment-simple", fmt.Sprintf("A=%d", i)).Output()
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(out).To(o.ContainSubstring("updated"))
default:
// wait for the deployment to be running
e2e.Logf("%02d: waiting for current deployment to start running", i)
o.Expect(waitForLatestCondition(oc, "deployment-simple", deploymentRunTimeout, deploymentRunning)).NotTo(o.HaveOccurred())
}
}
// trigger one more deployment, just in case we cancelled the latest output
out, err := oc.Run("set", "env").Args("dc/deployment-simple", fmt.Sprintf("A=%d", iterations)).Output()
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(out).To(o.ContainSubstring("updated"))
g.By("verifying all but terminal deployment is marked complete")
o.Expect(waitForLatestCondition(oc, "deployment-simple", deploymentRunTimeout, deploymentReachedCompletion)).NotTo(o.HaveOccurred())
})
g.It("should immediately start a new deployment", func() {
resource, name, err := createFixture(oc, simpleDeploymentFixture)
o.Expect(err).NotTo(o.HaveOccurred())
_, err = oc.Run("set", "env").Args(resource, "TRY=ONCE").Output()
o.Expect(err).NotTo(o.HaveOccurred())
g.By(fmt.Sprintf("by checking that the deployment config has the correct version"))
err = wait.PollImmediate(500*time.Millisecond, 5*time.Second, func() (bool, error) {
dc, _, _, err := deploymentInfo(oc, name)
if err != nil {
return false, nil
}
return dc.Status.LatestVersion == 2, nil
})
o.Expect(err).NotTo(o.HaveOccurred())
g.By(fmt.Sprintf("by checking that the second deployment exists"))
// TODO when #11016 gets fixed this can be reverted to 30seconds
err = wait.PollImmediate(500*time.Millisecond, 5*time.Minute, func() (bool, error) {
_, rcs, _, err := deploymentInfo(oc, name)
if err != nil {
return false, nil
}
secondDeploymentExists := false
for _, rc := range rcs {
if rc.Name == deployutil.DeploymentNameForConfigVersion(name, 2) {
secondDeploymentExists = true
break
}
}
return secondDeploymentExists, nil
})
o.Expect(err).NotTo(o.HaveOccurred())
g.By(fmt.Sprintf("by checking that the first deployer was deleted and the second deployer exists"))
err = wait.PollImmediate(500*time.Millisecond, 10*time.Second, func() (bool, error) {
_, _, pods, err := deploymentInfo(oc, name)
if err != nil {
return false, nil
}
deploymentNamesToDeployers, err := deploymentPods(pods)
if err != nil {
return false, nil
}
firstDeploymentName := deployutil.DeploymentNameForConfigVersion(name, 1)
firstDeployerRemoved := len(deploymentNamesToDeployers[firstDeploymentName]) == 0
secondDeploymentName := deployutil.DeploymentNameForConfigVersion(name, 2)
secondDeployerExists := len(deploymentNamesToDeployers[secondDeploymentName]) == 1
return firstDeployerRemoved && secondDeployerExists, nil
})
o.Expect(err).NotTo(o.HaveOccurred())
})
})
g.Describe("should respect image stream tag reference policy [Conformance]", func() {
g.AfterEach(func() {
failureTrap(oc, "deployment-image-resolution", g.CurrentGinkgoTestDescription().Failed)
})
g.It("resolve the image pull spec", func() {
o.Expect(oc.Run("create").Args("-f", resolutionFixture).Execute()).NotTo(o.HaveOccurred())
name := "deployment-image-resolution"
o.Expect(waitForLatestCondition(oc, name, deploymentRunTimeout, deploymentImageTriggersResolved(2))).NotTo(o.HaveOccurred())
is, err := oc.Client().ImageStreams(oc.Namespace()).Get(name, metav1.GetOptions{})
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(is.Status.DockerImageRepository).NotTo(o.BeEmpty())
o.Expect(is.Status.Tags["direct"].Items).NotTo(o.BeEmpty())
o.Expect(is.Status.Tags["pullthrough"].Items).NotTo(o.BeEmpty())
dc, err := oc.Client().DeploymentConfigs(oc.Namespace()).Get(name, metav1.GetOptions{})
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(dc.Spec.Triggers).To(o.HaveLen(3))
imageID := is.Status.Tags["pullthrough"].Items[0].Image
resolvedReference := fmt.Sprintf("%s@%s", is.Status.DockerImageRepository, imageID)
directReference := is.Status.Tags["direct"].Items[0].DockerImageReference
// controller should be using pullthrough for this (pointing to local registry)
o.Expect(dc.Spec.Triggers[1].ImageChangeParams).NotTo(o.BeNil())
o.Expect(dc.Spec.Triggers[1].ImageChangeParams.LastTriggeredImage).To(o.Equal(resolvedReference))
o.Expect(dc.Spec.Template.Spec.Containers[0].Image).To(o.Equal(resolvedReference))
// controller should have preferred the base image
o.Expect(dc.Spec.Triggers[2].ImageChangeParams).NotTo(o.BeNil())
o.Expect(dc.Spec.Triggers[2].ImageChangeParams.LastTriggeredImage).To(o.Equal(directReference))
o.Expect(dc.Spec.Template.Spec.Containers[1].Image).To(o.Equal(directReference))
})
})
g.Describe("with test deployments [Conformance]", func() {
g.AfterEach(func() {
failureTrap(oc, "deployment-test", g.CurrentGinkgoTestDescription().Failed)
})
g.It("should run a deployment to completion and then scale to zero", func() {
out, err := oc.Run("create").Args("-f", deploymentFixture).Output()
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(waitForLatestCondition(oc, "deployment-test", deploymentRunTimeout, deploymentRunning)).NotTo(o.HaveOccurred())
out, err = oc.Run("logs").Args("-f", "dc/deployment-test").Output()
o.Expect(err).NotTo(o.HaveOccurred())
g.By(fmt.Sprintf("checking the logs for substrings\n%s", out))
o.Expect(out).To(o.ContainSubstring("deployment-test-1 to 2"))
o.Expect(out).To(o.ContainSubstring("--> pre: Success"))
// FIXME: In some cases the last log messages is lost because of the journald rate
// limiter bug. For this test it should be enough to verify the deployment is marked
// as complete. We should uncomment this once the rate-limiter issues are fixed.
// o.Expect(out).To(o.ContainSubstring("--> Success"))
g.By("verifying the deployment is marked complete and scaled to zero")
o.Expect(waitForLatestCondition(oc, "deployment-test", deploymentRunTimeout, deploymentReachedCompletion)).NotTo(o.HaveOccurred())
g.By("verifying that scaling does not result in new pods")
out, err = oc.Run("scale").Args("dc/deployment-test", "--replicas=1").Output()
o.Expect(err).NotTo(o.HaveOccurred())
g.By("ensuring no scale up of the deployment happens")
wait.PollImmediate(100*time.Millisecond, 10*time.Second, func() (bool, error) {
rc, err := oc.KubeClient().CoreV1().ReplicationControllers(oc.Namespace()).Get("deployment-test-1", metav1.GetOptions{})
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(*rc.Spec.Replicas).Should(o.BeEquivalentTo(0))
o.Expect(rc.Status.Replicas).Should(o.BeEquivalentTo(0))
return false, nil
})
g.By("verifying the scale is updated on the deployment config")
config, err := oc.Client().DeploymentConfigs(oc.Namespace()).Get("deployment-test", metav1.GetOptions{})
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(config.Spec.Replicas).Should(o.BeEquivalentTo(1))
o.Expect(config.Spec.Test).Should(o.BeTrue())
g.By("deploying a few more times")
for i := 0; i < 3; i++ {
rolloutCompleteWithLogs := make(chan struct{})
out := ""
go func(rolloutNumber int) {
defer g.GinkgoRecover()
defer close(rolloutCompleteWithLogs)
var err error
out, err = waitForDeployerToComplete(oc, fmt.Sprintf("deployment-test-%d", rolloutNumber), deploymentRunTimeout)
o.Expect(err).NotTo(o.HaveOccurred())
}(i + 2) // we already did 2 rollouts previously.
// When the rollout latest is called, we already waiting for the replication
// controller to be created and scrubbing the deployer logs as soon as the
// deployer container runs.
_, err := oc.Run("rollout").Args("latest", "deployment-test").Output()
o.Expect(err).NotTo(o.HaveOccurred())
g.By(fmt.Sprintf("waiting for the rollout #%d to finish", i+2))
<-rolloutCompleteWithLogs
o.Expect(out).NotTo(o.BeEmpty())
o.Expect(waitForLatestCondition(oc, "deployment-test", deploymentRunTimeout, deploymentReachedCompletion)).NotTo(o.HaveOccurred())
g.By(fmt.Sprintf("checking the logs for substrings\n%s", out))
o.Expect(out).To(o.ContainSubstring(fmt.Sprintf("deployment-test-%d up to 1", i+2)))
o.Expect(out).To(o.ContainSubstring("--> pre: Success"))
o.Expect(out).To(o.ContainSubstring("test pre hook executed"))
// FIXME: In some cases the last log messages is lost because of the journald rate
// limiter bug. For this test it should be enough to verify the deployment is marked
// as complete. We should uncomment this once the rate-limiter issues are fixed.
// o.Expect(out).To(o.ContainSubstring("--> Success"))
}
})
})
g.Describe("when changing image change trigger [Conformance]", func() {
g.AfterEach(func() {
failureTrap(oc, "example", g.CurrentGinkgoTestDescription().Failed)
})
g.It("should successfully trigger from an updated image", func() {
_, name, err := createFixture(oc, imageChangeTriggerFixture)
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(waitForSyncedConfig(oc, name, deploymentRunTimeout)).NotTo(o.HaveOccurred())
g.By("tagging the busybox:latest as test:v1 image")
_, err = oc.Run("tag").Args("docker.io/busybox:latest", "test:v1").Output()
o.Expect(err).NotTo(o.HaveOccurred())
expectLatestVersion := func(version int) {
dc, err := oc.Client().DeploymentConfigs(oc.Namespace()).Get(name, metav1.GetOptions{})
o.Expect(err).NotTo(o.HaveOccurred())
latestVersion := dc.Status.LatestVersion
err = wait.PollImmediate(500*time.Millisecond, 10*time.Second, func() (bool, error) {
dc, err = oc.Client().DeploymentConfigs(oc.Namespace()).Get(name, metav1.GetOptions{})
o.Expect(err).NotTo(o.HaveOccurred())
latestVersion = dc.Status.LatestVersion
return latestVersion == int64(version), nil
})
if err == wait.ErrWaitTimeout {
err = fmt.Errorf("expected latestVersion: %d, got: %d", version, latestVersion)
}
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(waitForLatestCondition(oc, name, deploymentRunTimeout, deploymentReachedCompletion)).NotTo(o.HaveOccurred())
}
g.By("ensuring the deployment config latest version is 1 and rollout completed")
expectLatestVersion(1)
g.By("updating the image change trigger to point to test:v2 image")
_, err = oc.Run("set").Args("triggers", "dc/"+name, "--remove-all").Output()
o.Expect(err).NotTo(o.HaveOccurred())
_, err = oc.Run("set").Args("triggers", "dc/"+name, "--from-image", "test:v2", "--auto", "-c", "test").Output()
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(waitForSyncedConfig(oc, name, deploymentRunTimeout)).NotTo(o.HaveOccurred())
g.By("tagging the busybox:1.25 as test:v2 image")
_, err = oc.Run("tag").Args("docker.io/busybox:1.25", "test:v2").Output()
o.Expect(err).NotTo(o.HaveOccurred())
g.By("ensuring the deployment config latest version is 2 and rollout completed")
expectLatestVersion(2)
})
})
g.Describe("when tagging images [Conformance]", func() {
g.AfterEach(func() {
failureTrap(oc, "tag-images", g.CurrentGinkgoTestDescription().Failed)
})
g.It("should successfully tag the deployed image", func() {
g.By("creating the deployment config fixture")
_, name, err := createFixture(oc, tagImagesFixture)
o.Expect(err).NotTo(o.HaveOccurred())
g.By("verifying the deployment is marked complete")
o.Expect(waitForLatestCondition(oc, name, deploymentRunTimeout, deploymentReachedCompletion)).NotTo(o.HaveOccurred())
g.By("verifying the deployer service account can update imagestreamtags and user can get them")
err = exutil.WaitForUserBeAuthorized(oc, oc.Username(), "get", "imagestreamtags")
o.Expect(err).NotTo(o.HaveOccurred())
err = exutil.WaitForUserBeAuthorized(oc, "system:serviceaccount:"+oc.Namespace()+":deployer", "update", "imagestreamtags")
o.Expect(err).NotTo(o.HaveOccurred())
g.By("verifying the post deployment action happened: tag is set")
var istag *imageapi.ImageStreamTag
pollErr := wait.PollImmediate(100*time.Millisecond, 1*time.Minute, func() (bool, error) {
istag, err = oc.Client().ImageStreamTags(oc.Namespace()).Get("sample-stream", "deployed")
if kerrors.IsNotFound(err) {
return false, nil
}
if err != nil {
return false, err
}
return true, nil
})
if pollErr == wait.ErrWaitTimeout {
pollErr = err
}
o.Expect(pollErr).NotTo(o.HaveOccurred())
if istag.Tag == nil || istag.Tag.From == nil || istag.Tag.From.Name != "openshift/origin-pod" {
err = fmt.Errorf("expected %q to be part of the image reference in %#v", "openshift/origin-pod", istag)
o.Expect(err).NotTo(o.HaveOccurred())
}
})
})
g.Describe("with env in params referencing the configmap [Conformance]", func() {
g.AfterEach(func() {
failureTrap(oc, "deployment-simple", g.CurrentGinkgoTestDescription().Failed)
})
g.It("should expand the config map key to a value", func() {
_, err := oc.Run("create").Args("configmap", "test", "--from-literal=foo=bar").Output()
o.Expect(err).NotTo(o.HaveOccurred())
_, name, err := createFixture(oc, envRefDeploymentFixture)
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(waitForSyncedConfig(oc, name, deploymentRunTimeout)).NotTo(o.HaveOccurred())
_, err = oc.Run("rollout").Args("latest", "dc/"+name).Output()
o.Expect(err).NotTo(o.HaveOccurred())
out, _ := oc.Run("rollout").Args("status", "dc/"+name).Output()
o.Expect(out).To(o.ContainSubstring("has failed progressing"))
out, err = oc.Run("logs").Args("dc/" + name).Output()
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(out).To(o.ContainSubstring("hello bar"))
})
})
g.Describe("with multiple image change triggers [Conformance]", func() {
g.AfterEach(func() {
failureTrap(oc, "deployment-simple", g.CurrentGinkgoTestDescription().Failed)
})
g.It("should run a successful deployment with multiple triggers", func() {
_, name, err := createFixture(oc, multipleICTFixture)
o.Expect(err).NotTo(o.HaveOccurred())
g.By("verifying the deployment is marked complete")
o.Expect(waitForLatestCondition(oc, name, deploymentRunTimeout, deploymentReachedCompletion)).NotTo(o.HaveOccurred())
})
g.It("should run a successful deployment with a trigger used by different containers", func() {
_, name, err := createFixture(oc, anotherMultiICTFixture)
o.Expect(err).NotTo(o.HaveOccurred())
g.By("verifying the deployment is marked complete")
o.Expect(waitForLatestCondition(oc, name, deploymentRunTimeout, deploymentReachedCompletion)).NotTo(o.HaveOccurred())
})
})
g.Describe("with enhanced status [Conformance]", func() {
g.AfterEach(func() {
failureTrap(oc, "deployment-simple", g.CurrentGinkgoTestDescription().Failed)
})
g.It("should include various info in status", func() {
resource, name, err := createFixture(oc, simpleDeploymentFixture)
o.Expect(err).NotTo(o.HaveOccurred())
g.By("verifying the deployment is marked complete")
o.Expect(waitForLatestCondition(oc, name, deploymentRunTimeout, deploymentReachedCompletion)).NotTo(o.HaveOccurred())
g.By("verifying that status.replicas is set")
replicas, err := oc.Run("get").Args(resource, "--output=jsonpath=\"{.status.replicas}\"").Output()
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(replicas).To(o.ContainSubstring("2"))
g.By("verifying that status.updatedReplicas is set")
updatedReplicas, err := oc.Run("get").Args(resource, "--output=jsonpath=\"{.status.updatedReplicas}\"").Output()
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(updatedReplicas).To(o.ContainSubstring("2"))
g.By("verifying that status.availableReplicas is set")
availableReplicas, err := oc.Run("get").Args(resource, "--output=jsonpath=\"{.status.availableReplicas}\"").Output()
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(availableReplicas).To(o.ContainSubstring("2"))
g.By("verifying that status.unavailableReplicas is set")
unavailableReplicas, err := oc.Run("get").Args(resource, "--output=jsonpath=\"{.status.unavailableReplicas}\"").Output()
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(unavailableReplicas).To(o.ContainSubstring("0"))
})
})
g.Describe("with custom deployments [Conformance]", func() {
g.AfterEach(func() {
failureTrap(oc, "custom-deployment", g.CurrentGinkgoTestDescription().Failed)
})
g.It("should run the custom deployment steps", func() {
out, err := oc.Run("create").Args("-f", customDeploymentFixture).Output()
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(waitForLatestCondition(oc, "custom-deployment", deploymentRunTimeout, deploymentRunning)).NotTo(o.HaveOccurred())
out, err = oc.Run("deploy").Args("--follow", "dc/custom-deployment").Output()
o.Expect(err).NotTo(o.HaveOccurred())
g.By("verifying the deployment is marked complete")
o.Expect(waitForLatestCondition(oc, "custom-deployment", deploymentRunTimeout, deploymentReachedCompletion)).NotTo(o.HaveOccurred())
g.By(fmt.Sprintf("checking the logs for substrings\n%s", out))
o.Expect(out).To(o.ContainSubstring("--> pre: Running hook pod ..."))
o.Expect(out).To(o.ContainSubstring("test pre hook executed"))
o.Expect(out).To(o.ContainSubstring("--> Scaling custom-deployment-1 to 2"))
o.Expect(out).To(o.ContainSubstring("--> Reached 50%"))
o.Expect(out).To(o.ContainSubstring("Halfway"))
o.Expect(out).To(o.ContainSubstring("Finished"))
// FIXME: In some cases the last log messages is lost because of the journald rate
// limiter bug. For this test it should be enough to verify the deployment is marked
// as complete. We should uncomment this once the rate-limiter issues are fixed.
// o.Expect(out).To(o.ContainSubstring("--> Success"))
})
})
g.Describe("viewing rollout history [Conformance]", func() {
g.AfterEach(func() {
failureTrap(oc, "deployment-simple", g.CurrentGinkgoTestDescription().Failed)
})
g.It("should print the rollout history", func() {
resource, name, err := createFixture(oc, simpleDeploymentFixture)
o.Expect(err).NotTo(o.HaveOccurred())
g.By("waiting for the first rollout to complete")
o.Expect(waitForLatestCondition(oc, name, deploymentRunTimeout, deploymentReachedCompletion)).NotTo(o.HaveOccurred())
dc, err := oc.Client().DeploymentConfigs(oc.Namespace()).Get(name, metav1.GetOptions{})
o.Expect(err).NotTo(o.HaveOccurred())
g.By("updating the deployment config in order to trigger a new rollout")
_, err = client.UpdateConfigWithRetries(oc.Client(), oc.Namespace(), name, func(update *deployapi.DeploymentConfig) {
one := int64(1)
update.Spec.Template.Spec.TerminationGracePeriodSeconds = &one
})
o.Expect(err).NotTo(o.HaveOccurred())
// Wait for latestVersion=2 to be surfaced in the API
latestVersion := dc.Status.LatestVersion
err = wait.PollImmediate(500*time.Millisecond, 10*time.Second, func() (bool, error) {
dc, err = oc.Client().DeploymentConfigs(oc.Namespace()).Get(name, metav1.GetOptions{})
if err != nil {
return false, err
}
latestVersion = dc.Status.LatestVersion
return latestVersion == 2, nil
})
if err == wait.ErrWaitTimeout {
err = fmt.Errorf("expected latestVersion: 2, got: %d", latestVersion)
}
o.Expect(err).NotTo(o.HaveOccurred())
g.By("waiting for the second rollout to complete")
o.Expect(waitForLatestCondition(oc, name, deploymentRunTimeout, deploymentReachedCompletion)).NotTo(o.HaveOccurred())
out, err := oc.Run("rollout").Args("history", resource).Output()
o.Expect(err).NotTo(o.HaveOccurred())
g.By(fmt.Sprintf("checking the history for substrings\n%s", out))
o.Expect(out).To(o.ContainSubstring("deploymentconfigs \"deployment-simple\""))
o.Expect(out).To(o.ContainSubstring("REVISION STATUS CAUSE"))
o.Expect(out).To(o.ContainSubstring("1 Complete config change"))
o.Expect(out).To(o.ContainSubstring("2 Complete config change"))
})
})
g.Describe("generation [Conformance]", func() {
g.AfterEach(func() {
failureTrap(oc, "generation-test", g.CurrentGinkgoTestDescription().Failed)
})
g.It("should deploy based on a status version bump", func() {
resource, name, err := createFixture(oc, generationFixture)
o.Expect(err).NotTo(o.HaveOccurred())
g.By("verifying that both latestVersion and generation are updated")
var generation, version string
err = wait.PollImmediate(500*time.Millisecond, 10*time.Second, func() (bool, error) {
version, err = oc.Run("get").Args(resource, "--output=jsonpath=\"{.status.latestVersion}\"").Output()
if err != nil {
return false, nil
}
version = strings.Trim(version, "\"")
g.By(fmt.Sprintf("checking the latest version for %s: %s", resource, version))
generation, err = oc.Run("get").Args(resource, "--output=jsonpath=\"{.metadata.generation}\"").Output()
if err != nil {
return false, nil
}
generation = strings.Trim(generation, "\"")
g.By(fmt.Sprintf("checking the generation for %s: %s", resource, generation))
return strings.Contains(generation, "2") && strings.Contains(version, "1"), nil
})
if err == wait.ErrWaitTimeout {
err = fmt.Errorf("expected generation: 2, got: %s, expected latestVersion: 1, got: %s", generation, version)
}
o.Expect(err).NotTo(o.HaveOccurred())
g.By("verifying the deployment is marked complete")
o.Expect(waitForLatestCondition(oc, name, deploymentRunTimeout, deploymentReachedCompletion)).NotTo(o.HaveOccurred())
g.By("verifying that scaling updates the generation")
_, err = oc.Run("scale").Args(resource, "--replicas=2").Output()
o.Expect(err).NotTo(o.HaveOccurred())
err = wait.PollImmediate(500*time.Millisecond, 10*time.Second, func() (bool, error) {
generation, err = oc.Run("get").Args(resource, "--output=jsonpath=\"{.metadata.generation}\"").Output()
if err != nil {
return false, nil
}
generation = strings.Trim(generation, "\"")
g.By(fmt.Sprintf("checking the generation for %s: %s", resource, generation))
return strings.Contains(generation, "3"), nil
})
if err == wait.ErrWaitTimeout {
err = fmt.Errorf("expected generation: 3, got: %s", generation)
}
o.Expect(err).NotTo(o.HaveOccurred())
g.By("deploying a second time [new client]")
_, err = oc.Run("rollout").Args("latest", name).Output()
o.Expect(err).NotTo(o.HaveOccurred())
g.By("verifying that both latestVersion and generation are updated")
err = wait.PollImmediate(500*time.Millisecond, 10*time.Second, func() (bool, error) {
version, err = oc.Run("get").Args(resource, "--output=jsonpath=\"{.status.latestVersion}\"").Output()
if err != nil {
return false, nil
}
version = strings.Trim(version, "\"")
g.By(fmt.Sprintf("checking the latest version for %s: %s", resource, version))
generation, err = oc.Run("get").Args(resource, "--output=jsonpath=\"{.metadata.generation}\"").Output()
if err != nil {
return false, nil
}
generation = strings.Trim(generation, "\"")
g.By(fmt.Sprintf("checking the generation for %s: %s", resource, generation))
return strings.Contains(generation, "4") && strings.Contains(version, "2"), nil
})
if err == wait.ErrWaitTimeout {
err = fmt.Errorf("expected generation: 4, got: %s, expected latestVersion: 2, got: %s", generation, version)
}
o.Expect(err).NotTo(o.HaveOccurred())
g.By("verifying that observedGeneration equals generation")
o.Expect(waitForSyncedConfig(oc, name, deploymentRunTimeout)).NotTo(o.HaveOccurred())
})
})
g.Describe("paused [Conformance]", func() {
g.AfterEach(func() {
failureTrap(oc, "paused", g.CurrentGinkgoTestDescription().Failed)
})
g.It("should disable actions on deployments", func() {
resource, name, err := createFixture(oc, pausedDeploymentFixture)
o.Expect(err).NotTo(o.HaveOccurred())
_, rcs, _, err := deploymentInfo(oc, name)
o.Expect(err).NotTo(o.HaveOccurred())
if len(rcs) != 0 {
o.Expect(fmt.Errorf("expected no deployment, found %#v", rcs[0])).NotTo(o.HaveOccurred())
}
g.By("verifying that we cannot start a new deployment via oc deploy")
out, err := oc.Run("deploy").Args(resource, "--latest").Output()
o.Expect(err).To(o.HaveOccurred())
o.Expect(out).To(o.ContainSubstring("cannot deploy a paused deployment config"))
g.By("verifying that we cannot start a new deployment via oc rollout")
out, err = oc.Run("rollout").Args("latest", resource).Output()
o.Expect(err).To(o.HaveOccurred())
o.Expect(out).To(o.ContainSubstring("cannot deploy a paused deployment config"))
g.By("verifying that we cannot cancel a deployment")
out, err = oc.Run("rollout").Args("cancel", resource).Output()
o.Expect(err).To(o.HaveOccurred())
o.Expect(out).To(o.ContainSubstring("unable to cancel paused deployment"))
g.By("verifying that we cannot retry a deployment")
out, err = oc.Run("deploy").Args(resource, "--retry").Output()
o.Expect(err).To(o.HaveOccurred())
o.Expect(out).To(o.ContainSubstring("cannot retry a paused deployment config"))
g.By("verifying that we cannot rollout retry a deployment")
out, err = oc.Run("rollout").Args("retry", resource).Output()
o.Expect(err).To(o.HaveOccurred())
o.Expect(out).To(o.ContainSubstring("unable to retry paused deployment"))
g.By("verifying that we cannot rollback a deployment")
out, err = oc.Run("rollback").Args(resource, "--to-version", "1").Output()
o.Expect(err).To(o.HaveOccurred())
o.Expect(out).To(o.ContainSubstring("cannot rollback a paused deployment config"))
_, rcs, _, err = deploymentInfo(oc, name)
o.Expect(err).NotTo(o.HaveOccurred())
if len(rcs) != 0 {
o.Expect(fmt.Errorf("expected no deployment, found %#v", rcs[0])).NotTo(o.HaveOccurred())
}
_, err = client.UpdateConfigWithRetries(oc.Client(), oc.Namespace(), name, func(dc *deployapi.DeploymentConfig) {
// TODO: oc rollout pause should patch instead of making a full update
dc.Spec.Paused = false
})
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(waitForLatestCondition(oc, name, deploymentRunTimeout, deploymentReachedCompletion)).NotTo(o.HaveOccurred())
})
})
g.Describe("with failing hook [Conformance]", func() {
g.AfterEach(func() {
failureTrap(oc, "hook", g.CurrentGinkgoTestDescription().Failed)
})
g.It("should get all logs from retried hooks", func() {
resource, name, err := createFixture(oc, failedHookFixture)
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(waitForLatestCondition(oc, name, deploymentRunTimeout, deploymentPreHookRetried)).NotTo(o.HaveOccurred())
out, err := oc.Run("logs").Args(resource).Output()
o.Expect(err).NotTo(o.HaveOccurred())
g.By(fmt.Sprintf("checking the logs for substrings\n%s", out))
o.Expect(out).To(o.ContainSubstring("--> pre: Running hook pod ..."))
o.Expect(out).To(o.ContainSubstring("pre hook logs"))
o.Expect(out).To(o.ContainSubstring("--> pre: Retrying hook pod (retry #1)"))
})
})
g.Describe("rolled back [Conformance]", func() {
g.AfterEach(func() {
failureTrap(oc, "deployment-simple", g.CurrentGinkgoTestDescription().Failed)
})
g.It("should rollback to an older deployment", func() {
resource, name, err := createFixture(oc, simpleDeploymentFixture)
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(waitForLatestCondition(oc, name, deploymentRunTimeout, deploymentReachedCompletion)).NotTo(o.HaveOccurred())
_, err = oc.Run("rollout").Args("latest", name).Output()
o.Expect(err).NotTo(o.HaveOccurred())
g.By("verifying that we are on the second version")
version := "1"
err = wait.PollImmediate(500*time.Millisecond, 30*time.Second, func() (bool, error) {
latestVersion, err := oc.Run("get").Args(resource, "--output=jsonpath=\"{.status.latestVersion}\"").Output()
if err != nil {
return false, err
}
version = strings.Trim(latestVersion, "\"")
return strings.Contains(version, "2"), nil
})
if err == wait.ErrWaitTimeout {
err = fmt.Errorf("expected latestVersion: 2, got: %s", version)
}
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(waitForLatestCondition(oc, name, deploymentRunTimeout, deploymentReachedCompletion)).NotTo(o.HaveOccurred())
g.By("verifying that we can rollback")
_, err = oc.Run("rollout").Args("undo", resource).Output()
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(waitForLatestCondition(oc, name, deploymentRunTimeout, deploymentReachedCompletion)).NotTo(o.HaveOccurred())
g.By("verifying that we are on the third version")
version, err = oc.Run("get").Args(resource, "--output=jsonpath=\"{.status.latestVersion}\"").Output()
o.Expect(err).NotTo(o.HaveOccurred())
version = strings.Trim(version, "\"")
o.Expect(version).To(o.ContainSubstring("3"))
})
})
g.Describe("reaper [Conformance]", func() {
g.AfterEach(func() {
failureTrap(oc, "brokendeployment", g.CurrentGinkgoTestDescription().Failed)
})
g.It("should delete all failed deployer pods and hook pods", func() {
resource, name, err := createFixture(oc, brokenDeploymentFixture)
o.Expect(err).NotTo(o.HaveOccurred())
g.By("waiting for the deployment to complete")
err = waitForLatestCondition(oc, name, deploymentRunTimeout, deploymentReachedCompletion)
o.Expect(err).To(o.HaveOccurred())
g.By("fetching the deployer pod")
out, err := oc.Run("get").Args("pod", fmt.Sprintf("%s-1-deploy", name)).Output()
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(out).To(o.ContainSubstring("Error"))
g.By("fetching the pre-hook pod")
out, err = oc.Run("get").Args("pod", fmt.Sprintf("%s-1-hook-pre", name)).Output()
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(out).To(o.ContainSubstring("Error"))
g.By("deleting the deployment config")
out, err = oc.Run("delete").Args(resource).Output()
o.Expect(err).NotTo(o.HaveOccurred())
g.By("fetching the deployer pod")
out, err = oc.Run("get").Args("pod", fmt.Sprintf("%s-1-deploy", name)).Output()
o.Expect(err).To(o.HaveOccurred())
o.Expect(out).To(o.ContainSubstring("not found"))
g.By("fetching the pre-hook pod")
out, err = oc.Run("get").Args("pod", fmt.Sprintf("%s-1-hook-pre", name)).Output()
o.Expect(err).To(o.HaveOccurred())
o.Expect(out).To(o.ContainSubstring("not found"))
})
})
g.Describe("initially [Conformance]", func() {
g.AfterEach(func() {
failureTrap(oc, "readiness", g.CurrentGinkgoTestDescription().Failed)
})
g.It("should not deploy if pods never transition to ready", func() {
_, name, err := createFixture(oc, readinessFixture)
o.Expect(err).NotTo(o.HaveOccurred())
g.By("waiting for the deployment to fail")
err = waitForLatestCondition(oc, name, deploymentRunTimeout, deploymentFailed)
o.Expect(err).NotTo(o.HaveOccurred())
})
})
g.Describe("with revision history limits [Conformance]", func() {
g.AfterEach(func() {
failureTrap(oc, "history-limit", g.CurrentGinkgoTestDescription().Failed)
})
g.It("should never persist more old deployments than acceptable after being observed by the controller", func() {
revisionHistoryLimit := 3 // as specified in the fixture
dc, err := createDeploymentConfig(oc, historyLimitedDeploymentFixture)
o.Expect(err).NotTo(o.HaveOccurred())
deploymentTimeout := time.Duration(*dc.Spec.Strategy.RollingParams.TimeoutSeconds) * time.Second
iterations := 10
for i := 0; i < iterations; i++ {
o.Expect(waitForLatestCondition(oc, "history-limit", deploymentTimeout, deploymentReachedCompletion)).NotTo(o.HaveOccurred(),
"the current deployment needs to have finished before attempting to trigger a new deployment through configuration change")
e2e.Logf("%02d: triggering a new deployment with config change", i)
out, err := oc.Run("set", "env").Args("dc/history-limit", fmt.Sprintf("A=%d", i)).Output()
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(out).To(o.ContainSubstring("updated"))
}
o.Expect(waitForSyncedConfig(oc, "history-limit", deploymentRunTimeout)).NotTo(o.HaveOccurred())
g.By("waiting for the deployment to complete")
o.Expect(waitForLatestCondition(oc, "history-limit", deploymentTimeout, deploymentReachedCompletion)).NotTo(o.HaveOccurred())
o.Expect(waitForSyncedConfig(oc, "history-limit", deploymentRunTimeout)).NotTo(o.HaveOccurred(),
"the controller needs to have synced with the updated deployment configuration before checking that the revision history limits are being adhered to")
var pollErr error
err = wait.PollImmediate(1*time.Second, 1*time.Minute, func() (bool, error) {
deploymentConfig, deployments, _, err := deploymentInfo(oc, "history-limit")
if err != nil {
pollErr = err
return false, nil
}
// we need to filter out any deployments that we don't care about,
// namely the active deployment and any newer deployments
oldDeployments := deployutil.DeploymentsForCleanup(deploymentConfig, deployments)
// we should not have more deployments than acceptable
if len(oldDeployments) != revisionHistoryLimit {
pollErr = fmt.Errorf("expected len of old deployments: %d to equal dc revisionHistoryLimit: %d", len(oldDeployments), revisionHistoryLimit)
return false, nil
}
// the deployments we continue to keep should be the latest ones
for _, deployment := range oldDeployments {
o.Expect(deployutil.DeploymentVersionFor(&deployment)).To(o.BeNumerically(">=", iterations-revisionHistoryLimit))
}
return true, nil
})
if err == wait.ErrWaitTimeout {
err = pollErr
}
o.Expect(err).NotTo(o.HaveOccurred())
})
})
g.Describe("with minimum ready seconds set [Conformance]", func() {
dc := readDCFixtureOrDie(minReadySecondsFixture)
rcName := func(i int) string { return fmt.Sprintf("%s-%d", dc.Name, i) }
g.AfterEach(func() {
failureTrap(oc, dc.Name, g.CurrentGinkgoTestDescription().Failed)
})
g.It("should not transition the deployment to Complete before satisfied", func() {
namespace := oc.Namespace()
watcher, err := oc.KubeClient().CoreV1().ReplicationControllers(namespace).Watch(metav1.SingleObject(metav1.ObjectMeta{Name: rcName(1), ResourceVersion: ""}))
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(dc.Spec.Triggers).To(o.BeNil())
// FIXME: remove when tests are migrated to the new client
// (the old one incorrectly translates nil into an empty array)
dc.Spec.Triggers = append(dc.Spec.Triggers, deployapi.DeploymentTriggerPolicy{Type: deployapi.DeploymentTriggerOnConfigChange})
dc, err = oc.Client().DeploymentConfigs(namespace).Create(dc)
o.Expect(err).NotTo(o.HaveOccurred())
g.By("verifying the deployment is created")
rcEvent, err := watch.Until(deploymentChangeTimeout, watcher, func(event watch.Event) (bool, error) {
if event.Type == watch.Added {
return true, nil
}
return false, fmt.Errorf("different kind of event appeared while waiting for Added event: %#v", event)
})
o.Expect(err).NotTo(o.HaveOccurred())
rc1 := rcEvent.Object.(*kapiv1.ReplicationController)
g.By("verifying that all pods are ready")
rc1, err = waitForRCModification(oc, namespace, rc1.Name, deploymentRunTimeout,
rc1.GetResourceVersion(), func(rc *kapiv1.ReplicationController) (bool, error) {
return rc.Status.ReadyReplicas == dc.Spec.Replicas, nil
})
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(rc1.Status.AvailableReplicas).To(o.BeZero())
g.By("verifying that the deployment is still running")
if deployutil.IsTerminatedDeployment(rc1) {
o.Expect(fmt.Errorf("expected deployment %q not to have terminated", rc1.Name)).NotTo(o.HaveOccurred())
}
g.By("waiting for the deployment to finish")
rc1, err = waitForRCModification(oc, namespace, rc1.Name,
deploymentChangeTimeout+time.Duration(dc.Spec.MinReadySeconds)*time.Second,
rc1.GetResourceVersion(), func(rc *kapiv1.ReplicationController) (bool, error) {
if rc.Status.AvailableReplicas == dc.Spec.Replicas {
return true, nil
}
// FIXME: There is a race between deployer pod updating phase and RC updating AvailableReplicas
// FIXME: Enable this when we switch pod acceptors to use RC AvailableReplicas with MinReadySecondsSet
//if deployutil.DeploymentStatusFor(rc) == deployapi.DeploymentStatusComplete {
// e2e.Logf("Failed RC: %#v", rc)
// return false, errors.New("deployment shouldn't be completed before ReadyReplicas become AvailableReplicas")
//}
return false, nil
})
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(rc1.Status.AvailableReplicas).To(o.Equal(dc.Spec.Replicas))
// FIXME: There is a race between deployer pod updating phase and RC updating AvailableReplicas
// FIXME: Enable this when we switch pod acceptors to use RC AvailableReplicas with MinReadySecondsSet
//// Deployment status can't be updated yet but should be right after
//o.Expect(deployutil.DeploymentStatusFor(rc1)).To(o.Equal(deployapi.DeploymentStatusRunning))
// It should finish right after
// FIXME: remove this condition when the above is fixed
if deployutil.DeploymentStatusFor(rc1) != deployapi.DeploymentStatusComplete {
// FIXME: remove this assertion when the above is fixed
o.Expect(deployutil.DeploymentStatusFor(rc1)).To(o.Equal(deployapi.DeploymentStatusRunning))
rc1, err = waitForRCModification(oc, namespace, rc1.Name, deploymentChangeTimeout,
rc1.GetResourceVersion(), func(rc *kapiv1.ReplicationController) (bool, error) {
return deployutil.DeploymentStatusFor(rc) == deployapi.DeploymentStatusComplete, nil
})
o.Expect(err).NotTo(o.HaveOccurred())
}
// We might check that minReadySecond passed between pods becoming ready
// and available but I don't think there is a way to get a timestamp from events
// and other ways are just flaky.
// But since we are reusing MinReadySeconds and AvailableReplicas from RC it should be tested there
})
})
g.Describe("ignores deployer and lets the config with a NewReplicationControllerCreated reason [Conformance]", func() {
g.AfterEach(func() {
failureTrap(oc, "database", g.CurrentGinkgoTestDescription().Failed)
})
g.It("should let the deployment config with a NewReplicationControllerCreated reason", func() {
_, name, err := createFixture(oc, ignoresDeployersFixture)
o.Expect(err).NotTo(o.HaveOccurred())
g.By("verifying that the deployment config is bumped to the first version")
err = wait.PollImmediate(500*time.Millisecond, 30*time.Second, func() (bool, error) {
dc, _, _, err := deploymentInfo(oc, name)
if err != nil {
return false, nil
}
return dc.Status.LatestVersion == 1, nil
})
if err == wait.ErrWaitTimeout {
err = fmt.Errorf("deployment config %q never incremented to the first version", name)
}
o.Expect(err).NotTo(o.HaveOccurred())
g.By("verifying that the deployment config has the desired condition and reason")
var conditions []deployapi.DeploymentCondition