From 030fac418365ea37f1b76201068d2591c998df76 Mon Sep 17 00:00:00 2001 From: Tomas Nozicka Date: Mon, 15 Jan 2018 23:25:13 +0100 Subject: [PATCH] Cleanup duplicate checking for empty images in DC controller loop --- .../deploymentconfig/deploymentconfig_controller.go | 8 -------- 1 file changed, 8 deletions(-) diff --git a/pkg/apps/controller/deploymentconfig/deploymentconfig_controller.go b/pkg/apps/controller/deploymentconfig/deploymentconfig_controller.go index 55e1fcb7b156..85c382aabb51 100644 --- a/pkg/apps/controller/deploymentconfig/deploymentconfig_controller.go +++ b/pkg/apps/controller/deploymentconfig/deploymentconfig_controller.go @@ -181,14 +181,6 @@ func (c *DeploymentConfigController) Handle(config *appsapi.DeploymentConfig) er return c.reconcileDeployments(existingDeployments, config, cm) } - // Never deploy with invalid or unresolved images - for i, container := range config.Spec.Template.Spec.Containers { - if len(strings.TrimSpace(container.Image)) == 0 { - glog.V(4).Infof("Postponing rollout #%d for DeploymentConfig %s/%s because of invalid or unresolved image for container #%d (name=%s)", config.Status.LatestVersion, config.Namespace, config.Name, i, container.Name) - return c.updateStatus(config, existingDeployments, true) - } - } - // No deployments are running and the latest deployment doesn't exist, so // create the new deployment. deployment, err := appsutil.MakeDeploymentV1(config, c.codec)