diff --git a/vendor/k8s.io/kubernetes/pkg/volume/rbd/rbd.go b/vendor/k8s.io/kubernetes/pkg/volume/rbd/rbd.go index 5674652aabe6..795632d87801 100644 --- a/vendor/k8s.io/kubernetes/pkg/volume/rbd/rbd.go +++ b/vendor/k8s.io/kubernetes/pkg/volume/rbd/rbd.go @@ -201,8 +201,7 @@ func (plugin *rbdPlugin) NewDeleter(spec *volume.Spec) (volume.Deleter, error) { secret, err := parsePVSecret(adminSecretNamespace, adminSecretName, plugin.host.GetKubeClient()) if err != nil { - // log error but don't return yet - glog.Errorf("failed to get admin secret from [%q/%q]: %v", adminSecretNamespace, adminSecretName, err) + return nil, fmt.Errorf("failed to get admin secret from [%q/%q]: %v", adminSecretNamespace, adminSecretName, err) } return plugin.newDeleterInternal(spec, admin, secret, &RBDUtil{}) } @@ -282,8 +281,7 @@ func (r *rbdVolumeProvisioner) Provision() (*api.PersistentVolume, error) { return nil, fmt.Errorf("missing Ceph admin secret name") } if secret, err = parsePVSecret(adminSecretNamespace, adminSecretName, r.plugin.host.GetKubeClient()); err != nil { - // log error but don't return yet - glog.Errorf("failed to get admin secret from [%q/%q]", adminSecretNamespace, adminSecretName) + return nil, fmt.Errorf("failed to get admin secret from [%q/%q]: %v", adminSecretNamespace, adminSecretName, err) } r.adminSecret = secret if len(r.Mon) < 1 { @@ -308,7 +306,7 @@ func (r *rbdVolumeProvisioner) Provision() (*api.PersistentVolume, error) { rbd, sizeMB, err := r.manager.CreateImage(r) if err != nil { glog.Errorf("rbd: create volume failed, err: %v", err) - return nil, fmt.Errorf("rbd: create volume failed, err: %v", err) + return nil, err } glog.Infof("successfully created rbd image %q", image) pv := new(api.PersistentVolume) diff --git a/vendor/k8s.io/kubernetes/pkg/volume/rbd/rbd_util.go b/vendor/k8s.io/kubernetes/pkg/volume/rbd/rbd_util.go index 5eca4c3621cf..694a892b8eb4 100644 --- a/vendor/k8s.io/kubernetes/pkg/volume/rbd/rbd_util.go +++ b/vendor/k8s.io/kubernetes/pkg/volume/rbd/rbd_util.go @@ -314,6 +314,7 @@ func (util *RBDUtil) DetachDisk(c rbdUnmounter, mntPath string) error { } func (util *RBDUtil) CreateImage(p *rbdVolumeProvisioner) (r *api.RBDVolumeSource, size int, err error) { + var output []byte capacity := p.options.PVC.Spec.Resources.Requests[api.ResourceName(api.ResourceStorage)] volSizeBytes := capacity.Value() // convert to MB that rbd defaults on @@ -327,7 +328,6 @@ func (util *RBDUtil) CreateImage(p *rbdVolumeProvisioner) (r *api.RBDVolumeSourc for i := start; i < start+l; i++ { mon := p.Mon[i%l] glog.V(4).Infof("rbd: create %s size %s using mon %s, pool %s id %s key %s", p.rbdMounter.Image, volSz, mon, p.rbdMounter.Pool, p.rbdMounter.adminId, p.rbdMounter.adminSecret) - var output []byte output, err = p.rbdMounter.plugin.execCommand("rbd", []string{"create", p.rbdMounter.Image, "--size", volSz, "--pool", p.rbdMounter.Pool, "--id", p.rbdMounter.adminId, "-m", mon, "--key=" + p.rbdMounter.adminSecret, "--image-format", "1"}) if err == nil { @@ -338,8 +338,7 @@ func (util *RBDUtil) CreateImage(p *rbdVolumeProvisioner) (r *api.RBDVolumeSourc } if err != nil { - glog.Errorf("rbd: Error creating rbd image: %v", err) - return nil, 0, err + return nil, 0, fmt.Errorf("failed to create rbd image: %v, command output: %s", err, string(output)) } return &api.RBDVolumeSource{ @@ -372,7 +371,7 @@ func (util *RBDUtil) DeleteImage(p *rbdVolumeDeleter) error { if err == nil { return nil } else { - glog.Errorf("failed to delete rbd image, error %v output %v", err, string(output)) + glog.Errorf("failed to delete rbd image: %v, command output: %s", err, string(output)) } } return err