-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conversions/deep copy and protobuff generation tools break down with go 1.7 #10696
Comments
i remember @mfojtik was saying this belongs upstream, not sure where in kube that belongs in, i'd open the issue against that. |
@PI-Victor this is because some libs moved in go-1.7 and I don't think we can fix this for 1.6 and below. Also this is not an error, but this is:
and it is because you use OSX binary in Linux system right? ;-) |
@mfojtik i fixed that, but yes that error was my goimports binary :) |
@PI-Victor @smarterclayton is there a fix for this error in upstream? |
Please file an upstream issue if there isn't one. |
Jessie Frazzelle had a 1.7 PR, she may have fixed it. |
this seems to be fixed upstream so i guess we're just waiting for rebase |
@PI-Victor now anymore, rebase landed 💥 |
(to note, the client set generator does not throw these errors anymore, so I assume protobuf && friends will be fixed now as well) |
i can confirm this is no longer an issue with 1.7, tested all of the above. proto/conv/deep_copy. |
hack/update-generated-conversions.sh
andhack/update-generated-deep-copies.sh
break down in go 1.7Steps To Reproduce
The text was updated successfully, but these errors were encountered: