k8s Unit Test Flake: TestServiceRegistryExternalTrafficBetaAnnotationHealthCheckNodePortUserAllocation

[stevekuznetsov]

=== RUN   TestServiceRegistryExternalTrafficBetaAnnotationHealthCheckNodePortUserAllocation
--- FAIL: TestServiceRegistryExternalTrafficBetaAnnotationHealthCheckNodePortUserAllocation (0.00s)
	rest_test.go:1012: Unexpected failure creating service Internal error occurred: Failed to allocate requested HealthCheck nodePort 30200: provided port is already allocated
panic: interface conversion: interface is nil, not *api.Service [recovered]
	panic: interface conversion: interface is nil, not *api.Service

goroutine 86 [running]:
panic(0x16cc7a0, 0xc4201c30c0)
	/usr/local/go/src/runtime/panic.go:500 +0x1ae
testing.tRunner.func1(0xc42041d440)
	/usr/local/go/src/testing/testing.go:579 +0x474
panic(0x16cc7a0, 0xc4201c30c0)
	/usr/local/go/src/runtime/panic.go:458 +0x271
github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/registry/core/service.TestServiceRegistryExternalTrafficBetaAnnotationHealthCheckNodePortUserAllocation(0xc42041d440)
	/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/registry/core/service/rest_test.go:1014 +0x58c
testing.tRunner(0xc42041d440, 0x198a298)
	/usr/local/go/src/testing/testing.go:610 +0xca
created by testing.(*T).Run
	/usr/local/go/src/testing/testing.go:646 +0x530

seen here

upstream: kubernetes/kubernetes#37982

[derekwaynecarr]

this is fixed upstream:
kubernetes/kubernetes#46060

we could pick this in origin or wait for next rebase. since flakes slow everyone down, i am inclined to pick it after master goes out.

@jboyd01 -- can you look at picking this change from upstream kube to origin? it's relatively small, and is a good example to teach you of the process.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[stevekuznetsov]

Picked up in the rebase

/close