Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestUpdateNode: taint_controller_test.go:440: Only one added taint tolerated: Unexepected test result. Expected delete true, got false #13946

Closed
mfojtik opened this issue Apr 28, 2017 · 4 comments · Fixed by #13953
Closed

TestUpdateNode: taint_controller_test.go:440: Only one added taint tolerated: Unexepected test result. Expected delete true, got false #13946

mfojtik opened this issue Apr 28, 2017 · 4 comments · Fixed by #13953
Assignees
@sttts
Labels
component/kubernetes kind/test-flake Categorizes issue or PR as related to test flakes. priority/P1

Comments

@mfojtik
Copy link
Contributor

mfojtik commented Apr 28, 2017

Seen here: https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_check/1531/testReport/junit/github.com_openshift_origin_vendor_k8s/io_kubernetes_pkg_controller_node/TestUpdateNode/

github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/controller/node.TestUpdateNode (from github.com_openshift_origin_vendor_k8s.io_kubernetes_pkg_controller_node)


=== RUN   TestUpdateNode
--- FAIL: TestUpdateNode (4.71s)
	taint_controller_test.go:440: Only one added taint tolerated: Unexepected test result. Expected delete true, got false
@mfojtik mfojtik added component/kubernetes kind/test-flake Categorizes issue or PR as related to test flakes. priority/P1 labels Apr 28, 2017
@mfojtik mfojtik mentioned this issue Apr 28, 2017
Merged
@mfojtik mfojtik assigned sttts and unassigned derekwaynecarr Apr 28, 2017
@mfojtik
Copy link
Contributor Author

mfojtik commented Apr 28, 2017

@sttts maybe related to #13941 ?

@mfojtik
Copy link
Contributor Author

mfojtik commented Apr 28, 2017

(also there is a typo in the error message ;-)

@sttts
Copy link
Contributor

sttts commented Apr 28, 2017

#13941 was only bad timing in the tests, time.Sleeps. Will take a look here.

@sttts
Copy link
Contributor

sttts commented Apr 28, 2017

This involves timing as well. It starts the controller, waits 200ms and hopes that the controller process everything.

@sttts sttts mentioned this issue Apr 28, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sttts sttts

Labels
component/kubernetes kind/test-flake Categorizes issue or PR as related to test flakes. priority/P1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

UPSTREAM: <carry>: taint-controller-tests: double 'a bit of time' to avoid flakes sttts/origin
3 participants
@mfojtik @sttts @derekwaynecarr