deployment config image = " " should use a different token

[derekwaynecarr]

upstream i wanted to update validation of containers to check for image with leading and trailing whitespace as i found events where pods like this got in our production system.

it came to my attention that deployment config was using a pod template spec in this manner.

i would like us to consider transitioning to another replacement token or phrase that does not violate leading and trailing whitespace validation.

Version

latest

Steps To Reproduce

n/a

Current Result

n/a

Expected Result

pod spec templates with image that has leading or trailing white space should fail validation.

Additional Information

kubernetes/kubernetes#47491
kubernetes/kubernetes#47490

[derekwaynecarr]

for reference, this came to my attention when debugging events in prod cluster.

xyz   5s        7d        46927     mongoxyz   Pod       spec.containers{mongodb}                  Warning   InspectFailed   {kubelet ip-removed}   Failed to apply default image tag " ": couldn't parse image reference " ": invalid reference format

we should verify that the controller will ensure this never sends a pod spec with this type of image when creating the final pod. i have the upstream pr to verify that that wont be allowed to happen.