Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getting logs via API prepends timestamp #2309

Closed
TomasTomecek opened this issue May 18, 2015 · 3 comments
Closed

getting logs via API prepends timestamp #2309

TomasTomecek opened this issue May 18, 2015 · 3 comments
Labels
component/logging kind/bug Categorizes issue or PR as related to a bug. priority/P2

Comments

@TomasTomecek
Copy link
Contributor

In our case the timestamp is a bit disturbing since our logs already have timestamps:

docker logs

2015-05-18 04:51:59,912 - dock.plugins.squash - DEBUG - Archive generated

API

2015-05-18T08:51:59.918042576Z 2015-05-18 04:51:59,912 - dock.plugins.squash - DEBUG - Archive generated

osc build-logs

2015-05-18T08:51:59.918094714Z 2015-05-18 04:51:59,912 - dock.plugins.squash - DEBUG - Archive generated

Would it possible to disable timestamping? Or even better, make it configurable.
@mfojtik
Copy link
Contributor

mfojtik commented May 18, 2015

@TomasTomecek +100 this is annoying me for a pretty long time. I think we should not use 'glog' to return logs here but just Printf()

@mfojtik
Copy link
Contributor

mfojtik commented May 18, 2015

@smarterclayton @TomasTomecek wonder if this add the first timestamp or the second...

https://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/kubelet/dockertools/manager.go#L223

@mfojtik mfojtik mentioned this issue May 18, 2015
Merged
@mfojtik
Copy link
Contributor

mfojtik commented May 18, 2015

Upstream: kubernetes/kubernetes#8407

@mfojtik mfojtik mentioned this issue May 18, 2015
Merged
@danmcp danmcp added kind/bug Categorizes issue or PR as related to a bug. priority/P2 component/logging labels May 18, 2015
@danmcp danmcp closed this as completed May 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/logging kind/bug Categorizes issue or PR as related to a bug. priority/P2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mfojtik @danmcp @TomasTomecek