Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand test stack with service providers to allow output testing #102

Open
dpwdec opened this issue Feb 3, 2023 · 2 comments · May be fixed by #101
Open

Expand test stack with service providers to allow output testing #102

dpwdec opened this issue Feb 3, 2023 · 2 comments · May be fixed by #101
Labels
kind/enhancement Improvements or new features

Comments

@dpwdec
Copy link

dpwdec commented Feb 3, 2023

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

There are currently overload test functions defined that allow you to test the outputs of a mock pulumi stack during unit testing, however there is no support for this of stack output testing when using a service provider.

The TestWithServiceProviderAsync doesn't offer any overloads that expose the outputs from a stack. Link here.

But there are examples of the TestAsync function that do exactly this. Link here.

Ideally the TestWithServiceProviderAsync function would have an expanded overload to support a return type with Task<(ImmutableArray<Resource> Resources, IDictionary<string, object?> Outputs)

Affected area/feature

dotnet SDK testing
@dpwdec dpwdec added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Feb 3, 2023
@dpwdec dpwdec linked a pull request Feb 3, 2023 that will close this issue
Open
@dpwdec
Copy link
Author

dpwdec commented Feb 3, 2023

I've raised a PR #101 with the change I think needs to happen to facilitate this but I may need some review support as I don't know if this constitutes a change requiring change log updates.

@dixler dixler removed the needs-triage Needs attention from the triage team label Feb 6, 2023
@dixler
Copy link
Contributor

dixler commented Feb 8, 2023

Removed triage label as the author has opened a PR to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Improvements or new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature: Add outputs yielding sp test stack func dpwdec/pulumi-dotnet
2 participants
@dixler @dpwdec