Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to work with react-router v7 #326

Open
mikeycoxon opened this issue Jan 15, 2025 · 0 comments
Open

Update to work with react-router v7 #326

mikeycoxon opened this issue Jan 15, 2025 · 0 comments

Comments

@mikeycoxon
Copy link

It a simple matter to make a version of this library with react router v7.

basically, its change the peer dependency from react-router-dom to react-router

and import that at the top of LinkContainer.js, as in:

import { useHref, useLocation, useMatch, useNavigate } from 'react-router';

everything else seems to work just fine. Two reasons why I didn't submit this as a PR were:

  1. didn't know if I had the privileges
  2. this would be a breaking change for anyone still reliant on react-routeer v6 (and therefore react-router-dom)

maybe publish a variant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant