Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug?]: in vinxi dev, isDev is only true on client-side #1796

Open
2 tasks done
huseeiin opened this issue Feb 11, 2025 · 1 comment
Open
2 tasks done

[Bug?]: in vinxi dev, isDev is only true on client-side #1796

huseeiin opened this issue Feb 11, 2025 · 1 comment
Labels
question Further information is requested vinxi related to vinxi

Comments

@huseeiin
Copy link
Contributor

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 😯

import { isDev } from "solid-js/web";

console.log(isDev);

// terminal: false
// browser console: true

Expected behavior 🤔

it should be true in both environments
the alternative i used is vite's import.meta.env.DEV which works more correctly

Steps to reproduce 🕹

No response

Context 🔦

No response

Your environment 🌎

@huseeiin huseeiin added the bug Something isn't working label Feb 11, 2025
@atilafassina atilafassina added the vinxi related to vinxi label Feb 12, 2025
@atilafassina
Copy link
Member

Thanks, @huseeiin

since isDev is part of core, this is an issue with its integration in Vinxi.
I'll dig around and see where the fix should be (Vinxi or Solid) and I'll report back once I have an answer where this will/should be addressed.

@atilafassina atilafassina added needs triage question Further information is requested and removed needs triage bug Something isn't working labels Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested vinxi related to vinxi
Projects
None yet
Development

No branches or pull requests

2 participants