Enable multi version single step downgrade for KRaft based clusters #10929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelMorrisEst
force-pushed
the
issue-10928
branch
2 times, most recently
from
9b600bd to
38f90ce
Compare
Signed-off-by: MichaelMorris <[email protected]>
MichaelMorrisEst
force-pushed
the
issue-10928
branch
from
38f90ce to
6831c64
Compare
|
@MichaelMorrisEst I guess this is ready for review and should match the approved proposal now, or? |
scholzj
reviewed
Feb 13, 2025
| try { | ||
| versionFrom = versions.version(highestKafkaVersion); | ||
| } catch (KafkaUpgradeException exception) { | ||
| // From version is unknown but thats ok for downgrade |
There was a problem hiding this comment.
Maybe we should log some warning here? If nothing else, it would be useful to have it tracked as part of the logs in case we are analyzing issues etc.
There was a problem hiding this comment.
Yes, I will add a log statement
...r/src/main/java/io/strimzi/operator/cluster/operator/assembly/KRaftVersionChangeCreator.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Should this be also unit tested for example here? KafkaUpgradeDowngradeWithKRaftMockTest
|
/azp run regression |
|
/azp run upgrade |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: MichaelMorris <[email protected]>
Yes |
2 tasks
scholzj
approved these changes
Feb 19, 2025
Comment on lines
98
to
103
| public static String getHigherVersionThanLatest() { | ||
| String[] parsedVersion = LATEST_KAFKA_VERSION.split("\\."); | ||
| int incrementedMinorVersion = Integer.parseInt(parsedVersion[1]) + 1; | ||
| parsedVersion[1] = Integer.toString(incrementedMinorVersion); | ||
| return String.join(".", parsedVersion); | ||
| } |
There was a problem hiding this comment.
Would it make sense to have instead some constant with something like 99.0.0?
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run upgrade |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: MichaelMorris <[email protected]>
katheris
approved these changes
Feb 20, 2025
ppatierno
reviewed
Feb 20, 2025
...r/src/main/java/io/strimzi/operator/cluster/operator/assembly/KRaftVersionChangeCreator.java
Show resolved
Hide resolved
Co-authored-by: Paolo Patierno <[email protected]> Signed-off-by: Michael Morris <[email protected]>
ppatierno
approved these changes
Feb 20, 2025
...r/src/main/java/io/strimzi/operator/cluster/operator/assembly/KRaftVersionChangeCreator.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Select the type of your PR
Description
Closes #10928
Introduces handling for encountering an unknown Kafka version in downgrade of a KRaft based cluster in order to enable multi version single step downgrade
Checklist
Please go through this checklist and make sure all applicable tasks have been done