Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests depend on presence of file outside of repo #30

Open
mfrancza opened this issue Jul 31, 2019 · 0 comments
Open

Unit tests depend on presence of file outside of repo #30

mfrancza opened this issue Jul 31, 2019 · 0 comments

Comments

@mfrancza
Copy link

The hyperloglog unit tests depend on the presence of /usr/share/dict/words (see

BoomFilters/hyperloglog_test.go

Line 34 in 611b3db

dict := "/usr/share/dict/words"
). It would be helpful to include the test data in the repo to ensure the tests work without modification on systems that don't follow that dictionary path convention or don't load a dictionary package.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mfrancza