Admin Area / Audit Logs: Remove Usages Of theme Object In Styled Components
#4317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrians5j
changed the title
theme object and refactortheme Object In Styled Components
Pavel910
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR removes usages of
themeobject in styled components in the Audit Logs package. Thethemeobject wasn't supposed to be used here since this is a Page Builder theme. Doesn't have anything to do with Admin Area theming.We are addressing this because, in a multi-theme setup, the previous code would break, completely preventing the user from using the Audit Logs module.
How Has This Been Tested?
Manually.
Documentation
Changelog.