Correct Prometeus Compose.yaml #766
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Volume mapping for the config like made a directory called prometheus.yaml not a file. It did not make sense to specify file names in the volume mappings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Updated the prometheus compose.yaml. The currently the prometheus.yaml volume mapping creates a directory in the container at /etc/prometheus/prometheus.yaml. The command in the compose file for the config sets the location at /etc/prometheus/prometheus.yaml which is a directory created by the volume mappings.
I removed the prometheus.yaml mapping from both sides of the volume mapping. This makes the config.file command correct and no longer errors with "prometheus.yaml is a directory".
Users need to create the prometheus.yaml config file in the host ./config/ folder.