Add DD_INSTRUMENTATION_INSTALL_TYPE variables for known install methods
#6695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6695) - mean (69ms) : 66, 71
. : milestone, 69,
master - mean (70ms) : 65, 75
. : milestone, 70,
section CallTarget+Inlining+NGEN
This PR (6695) - mean (992ms) : 970, 1013
. : milestone, 992,
master - mean (1,001ms) : 976, 1025
. : milestone, 1001,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6695) - mean (102ms) : 99, 104
. : milestone, 102,
master - mean (102ms) : 100, 105
. : milestone, 102,
section CallTarget+Inlining+NGEN
This PR (6695) - mean (669ms) : 651, 687
. : milestone, 669,
master - mean (725ms) : 664, 787
. : milestone, 725,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6695) - mean (89ms) : 87, 91
. : milestone, 89,
master - mean (100ms) : 92, 109
. : milestone, 100,
section CallTarget+Inlining+NGEN
This PR (6695) - mean (630ms) : 613, 646
. : milestone, 630,
master - mean (690ms) : 654, 726
. : milestone, 690,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6695) - mean (191ms) : 187, 196
. : milestone, 191,
master - mean (191ms) : 187, 194
. : milestone, 191,
section CallTarget+Inlining+NGEN
This PR (6695) - mean (1,107ms) : 1075, 1138
. : milestone, 1107,
master - mean (1,106ms) : 1081, 1132
. : milestone, 1106,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6695) - mean (271ms) : 266, 275
. : milestone, 271,
master - mean (270ms) : 266, 275
. : milestone, 270,
section CallTarget+Inlining+NGEN
This PR (6695) - mean (863ms) : 832, 893
. : milestone, 863,
master - mean (865ms) : 835, 894
. : milestone, 865,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6695) - mean (263ms) : 258, 268
. : milestone, 263,
master - mean (262ms) : 258, 266
. : milestone, 262,
section CallTarget+Inlining+NGEN
This PR (6695) - mean (844ms) : 802, 885
. : milestone, 844,
master - mean (847ms) : 813, 881
. : milestone, 847,
|
Benchmarks Report for tracer 🐌Benchmarks for #6695 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Slower
|
| Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 | 1.204 | 395.66 | 476.45 |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StartFinishSpan |
net6.0 | 395ns | 0.763ns | 2.96ns | 0.00817 | 0 | 0 | 576 B |
| master | StartFinishSpan |
netcoreapp3.1 | 563ns | 1.13ns | 4.37ns | 0.00781 | 0 | 0 | 576 B |
| master | StartFinishSpan |
net472 | 584ns | 0.913ns | 3.42ns | 0.0916 | 0 | 0 | 578 B |
| master | StartFinishScope |
net6.0 | 470ns | 0.94ns | 3.64ns | 0.00988 | 0 | 0 | 696 B |
| master | StartFinishScope |
netcoreapp3.1 | 683ns | 0.979ns | 3.66ns | 0.00936 | 0 | 0 | 696 B |
| master | StartFinishScope |
net472 | 804ns | 1.68ns | 6.49ns | 0.104 | 0 | 0 | 658 B |
| #6695 | StartFinishSpan |
net6.0 | 476ns | 0.271ns | 1.05ns | 0.00804 | 0 | 0 | 576 B |
| #6695 | StartFinishSpan |
netcoreapp3.1 | 582ns | 0.253ns | 0.98ns | 0.00809 | 0 | 0 | 576 B |
| #6695 | StartFinishSpan |
net472 | 582ns | 1.31ns | 5.07ns | 0.0916 | 0 | 0 | 578 B |
| #6695 | StartFinishScope |
net6.0 | 503ns | 0.142ns | 0.551ns | 0.00982 | 0 | 0 | 696 B |
| #6695 | StartFinishScope |
netcoreapp3.1 | 750ns | 1.65ns | 6.41ns | 0.00939 | 0 | 0 | 696 B |
| #6695 | StartFinishScope |
net472 | 846ns | 1.72ns | 6.66ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️
Faster 🎉 in #6695
Benchmark
base/diff
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0
1.171
718.39
613.27
| Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 | 1.171 | 718.39 | 613.27 |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunOnMethodBegin |
net6.0 | 717ns | 0.979ns | 3.79ns | 0.00978 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
netcoreapp3.1 | 928ns | 1.45ns | 5.44ns | 0.00949 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
net472 | 1.03μs | 3.58ns | 13.9ns | 0.104 | 0 | 0 | 658 B |
| #6695 | RunOnMethodBegin |
net6.0 | 613ns | 1.09ns | 4.22ns | 0.00973 | 0 | 0 | 696 B |
| #6695 | RunOnMethodBegin |
netcoreapp3.1 | 905ns | 1.33ns | 5.16ns | 0.00935 | 0 | 0 | 696 B |
| #6695 | RunOnMethodBegin |
net472 | 1.06μs | 2.39ns | 9.25ns | 0.104 | 0 | 0 | 658 B |
andrewlock
force-pushed
the
andrew/record-install-type
branch
from
044e0ca to
bf59f82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Add the
DD_INSTRUMENTATION_INSTALL_TYPEfor install types for which we can set itReason for change
The
DD_INSTRUMENTATION_INSTALL_TYPEis used to record when ssi instrumentation is used (for example). I think it makes sense to set this value for some of our installation methods (the ones that set variables automatically for users)Implementation details
Add
DD_INSTRUMENTATION_INSTALL_TYPEfor:windows_fleet_installer)dotnet_msi)dd-tracetool (dd_trace_tool)dd-dotnetlauncher (dd_dotnet_launcher)Test coverage
Added a small test to the
dd-dotnettest (because it was easy, and we were already testing this sort of thing). I don't think it's worth the effort to automatically test the rest personally, but if someone wants to ruin my day they have a great excuse.Other details
Note that
dd-dotnetdoesn't use a get env var wrapper, but that's by-design as it doesn't run in partial trust, and there are bigger problems if that fails!