Removed topology view and related code

[GilbertCherrie]

Fixes: #7918

Removed the topology view and deleted all code related to it.

Before:

After:

@miq-bot add_reviewer @kavyanekkalapu
@miq-bot add-label enhancement

[kavyanekkalapu]

@GilbertCherrie I feel we need to delete package too.

manageiq-ui-classic/package.json

Line 77 in 1236a25

"kubernetes-topology-graph": "~0.0.25",

[Fryguy]

Some more files I think you can delete:

$ find . -name *topology*
./app/controllers/cloud_topology_controller.rb
./app/views/shared/topology
./spec/javascripts/fixtures/json/cloud_topology_response.json
./spec/javascripts/fixtures/json/infra_topology_response.json
./spec/javascripts/fixtures/json/network_topology_response.json
./spec/javascripts/fixtures/json/container_topology_response.json

[Fryguy]

cc @jrafanie 🔴 🔥 ✂️

[jrafanie]

Wow, this method. 😭 At least, it's a little less complicated now. It's like trying to find Waldo looking for the when clause that doesn't follow the convention.

[jrafanie]

cc @jrafanie 🔴 🔥 ✂️

+14 −6,045 ... so awesome... Delete more code! 😉

[Fryguy]

LGTM; cc @chessbyte

[miq-bot]

Checked commit GilbertCherrie@57dee8f with ruby 2.6.3, rubocop 1.13.0, haml-lint 0.35.0, and yamllint
30 files checked, 6 offenses detected

app/helpers/application_helper/toolbar_chooser.rb

• ❗ - Line 32, Col 107 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 32, Col 67 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.

app/views/layouts/_tabs.html.haml

• ⚠️ - Line 56 - Style/IfInsideElse: Convert if nested inside else to elsif.
• ⚠️ - Line 57 - id attribute must be in lisp-case
• ⚠️ - Line 58 - id attribute must be in lisp-case
• ⚠️ - Line 62 - Avoid using instance variables in partials views