Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dialog tag specs #23155

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix dialog tag specs #23155

wants to merge 1 commit into from

Conversation

GilbertCherrie
Copy link
Member

Depends on: ManageIQ/manageiq-automation_engine#555

Fixes specs after automation engine code is changed for the tag field in this pr: ManageIQ/manageiq-automation_engine#555.

Reverting the tests back to before this pr: #23078

@GilbertCherrie GilbertCherrie requested a review from Fryguy as a code owner August 15, 2024 19:42
@GilbertCherrie GilbertCherrie mentioned this pull request Aug 15, 2024
Open
@GilbertCherrie
Copy link
Member Author

@miq-bot assign @jrafanie
@miq-bot add-label bug

@miq-bot miq-bot added the bug label Aug 15, 2024
@GilbertCherrie
Copy link
Member Author

@miq-bot add-reviewer @jrafanie

@miq-bot miq-bot requested a review from jrafanie August 15, 2024 19:50
This was referenced Aug 21, 2024
Open
Open
@GilbertCherrie
Copy link
Member Author

@miq-bot cross-repo-test ManageIQ/manageiq-automation_engine#555

miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Aug 21, 2024
@miq-bot
Running tests for GilbertCherrie
8f54e5e 
From Pull Request:  ManageIQ/manageiq#23155
miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Aug 21, 2024
@miq-bot
Running tests for GilbertCherrie
f596901 
From Pull Request:  ManageIQ/manageiq#23155
This was referenced Aug 21, 2024
Closed
Closed
@GilbertCherrie
Copy link
Member Author

GilbertCherrie commented Aug 21, 2024 •
edited
Loading

@miq-bot cross-repo-test ManageIQ/manageiq-automation_engine#555, ManageIQ/manageiq-ui-classic#9251

miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Aug 21, 2024
@miq-bot
Running tests for GilbertCherrie
9f240b2 
From Pull Request:  ManageIQ/manageiq#23155
@miq-bot miq-bot mentioned this pull request Aug 21, 2024
Open
miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Aug 21, 2024
@miq-bot
Running tests for GilbertCherrie
02ccefd 
From Pull Request:  ManageIQ/manageiq#23155
@miq-bot miq-bot mentioned this pull request Aug 21, 2024
Open
@GilbertCherrie GilbertCherrie force-pushed the fix_dialog_tag_specs branch 2 times, most recently from f7f5bc1 to ee5e5b6 Compare August 21, 2024 19:07
@GilbertCherrie
Copy link
Member Author

@miq-bot cross-repo-test ManageIQ/manageiq-automation_engine#555, ManageIQ/manageiq-ui-classic#9251

miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Aug 21, 2024
@miq-bot
Running tests for GilbertCherrie
924a2a7 
From Pull Request:  ManageIQ/manageiq#23155
@miq-bot miq-bot mentioned this pull request Aug 21, 2024
Open
miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Aug 21, 2024
@miq-bot
Running tests for GilbertCherrie
15b3a4b 
From Pull Request:  ManageIQ/manageiq#23155
@miq-bot miq-bot mentioned this pull request Aug 21, 2024
Open
This was referenced Aug 23, 2024
Open
Open
@GilbertCherrie
Copy link
Member Author

@miq-bot cross-repo-test ManageIQ/manageiq-automation_engine#555, ManageIQ/manageiq-ui-classic#9251

miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Aug 26, 2024
@miq-bot
Running tests for GilbertCherrie
d5b3535 
From Pull Request:  ManageIQ/manageiq#23155
@miq-bot miq-bot mentioned this pull request Aug 26, 2024
Open
miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Aug 26, 2024
@miq-bot
Running tests for GilbertCherrie
40a8a68 
From Pull Request:  ManageIQ/manageiq#23155
@miq-bot miq-bot mentioned this pull request Aug 26, 2024
Open
@GilbertCherrie GilbertCherrie force-pushed the fix_dialog_tag_specs branch 4 times, most recently from 9e8df23 to 64520e3 Compare August 26, 2024 20:19
@GilbertCherrie
Copy link
Member Author

@miq-bot cross-repo-test ManageIQ/manageiq-automation_engine#555, ManageIQ/manageiq-ui-classic#9251

miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Aug 26, 2024
@miq-bot
Running tests for GilbertCherrie
f1e29d5 
From Pull Request:  ManageIQ/manageiq#23155
@miq-bot miq-bot mentioned this pull request Aug 26, 2024
Open
miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Aug 26, 2024
@miq-bot
Running tests for GilbertCherrie
edd78ad 
From Pull Request:  ManageIQ/manageiq#23155
@miq-bot miq-bot mentioned this pull request Aug 26, 2024
Open
@GilbertCherrie GilbertCherrie force-pushed the fix_dialog_tag_specs branch 5 times, most recently from 15b03f3 to 4b50a80 Compare September 5, 2024 17:55
@miq-bot
Copy link
Member

miq-bot commented Sep 5, 2024

Checked commit GilbertCherrie@be8000f with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
3 files checked, 1 offense detected

app/models/service_orchestration/provision_tagging.rb

@miq-bot
Copy link
Member

miq-bot commented Nov 4, 2024

This pull request is not mergeable. Please rebase and repush.

@miq-bot miq-bot added the stale label Feb 10, 2025
@miq-bot
Copy link
Member

miq-bot commented Feb 10, 2025

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare left review comments

@Fryguy Fryguy Awaiting requested review from Fryguy Fryguy is a code owner

@jrafanie jrafanie Awaiting requested review from jrafanie

@kbrock kbrock Awaiting requested review from kbrock kbrock is a code owner

Assignees

@jrafanie jrafanie

Labels
bug stale unmergeable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GilbertCherrie @miq-bot @agrare @jrafanie