added changes to use perl from docker image instead of local #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@nareshkumarthota Looks good except some error message improvements commented inline.
Also submit similar changes for .bat files.
| @@ -130,8 +130,28 @@ ARG_JRESPLMNT_VERSION="na" | |||
| ARG_JRESPLMNT_SHORT_VERSION="na" | |||
| ARG_JRESPLMNT_HOTFIX="na" | |||
|
|
|||
| #Pre check perl existance | |||
| PERL_UTILITY_CHECK="false" | |||
There was a problem hiding this comment.
@nareshkumarthota can you rename PERL_UTILITY_CHECK flag to something like PERL_INSTALLED?
| if docker image inspect $PERL_UTILITY_IMAGE_NAME > /dev/null 2>&1; then | ||
| docker rmi -f $PERL_UTILITY_IMAGE_NAME > /dev/null 2>&1 | ||
| fi | ||
| echo "ERROR: Build tool[buildah] not supported. Please install docker or perl utility." |
There was a problem hiding this comment.
@nareshkumarthota buildah not supported is misleading. Improve error message with something like:
ERROR: PERL not installed. Please install PERL to proceed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #374