fix: remove trap from provision-ansible-service-broker.sh

[darahayes]

Motivation

I have noticed cases where this script has called this finish function in cases where everything was executed successfully and this causes the overall installer to fail. These trap features are useful for things like catching events and performing cleanups, removing files etc before exiting. In our case, it's not actually doing anything and it's unnecessary.

@ziccardi can you try this out and see if it makes any difference for you?

[ziccardi]

@darahayes : no luck on my issue -> https://gist.github.com/ziccardi/907050995ff7230e0ba7d54df13d705f

[camilamacedo86]

Hi folks,

It is a bug which happened 50% of the times at least in the PR CI. Locally, with iOS I could not face it.
Following the link opened for it aerogear-attic/minishift-mobilecore-addon#18

Also, check the following links.

• no matches for servicecatalog.k8s.io openshift/openshift-ansible#6377
• Ansible Service Broker fails to be deployed on Openshift 3.6 created using minishift openshift/ansible-service-broker#602
• no matches for servicecatalog.k8s.io openshift/origin#17642
• application redeployment is getting failed for OpenShift v3.7.0 fabric8io/fabric8-maven-plugin#1130

Maybe we can solve it as described here doing something similar to https://github.com/openshift/openshift-ansible/pull/6687/files

It means, that @ziccardi we can ignore this issue faced by you and we need just re-run the Jenkins. It will work.

[camilamacedo86]

It is LTGB for me. Hi @maleck13 and @david-martin have you any objection here?

[david-martin]

Seems reasonable

[david-martin]

@philbrookes Good to merge this?

[camilamacedo86]

@wtrocki I understand this one we can just merge. Any objection?

[wtrocki]

Tried this change before merge. Sounds reasonable.