Ability to add custom labels to the DB migration pods #1878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbilque
changed the title
rooftopcellist
approved these changes
Jun 12, 2024
rooftopcellist
force-pushed
the
awx_migration_pod_labels
branch
from
6d58951 to
1fda602
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR allows to add the labels defined in the
additional_labelsparameter to the DB migration pods.Useful when labels are used to control pod creation based on label rules.
ISSUE TYPE
ADDITIONAL INFORMATION
Currently, labels are added at the DB migration job level, but not in the migration pod associated with that job.
The creation of this pod may be blocked if, for example, there is a control system based on labels.
This change simply reproduces what exists in the definition of task and web pods.