Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amp config #1619

Merged
merged 5 commits into from
Aug 3, 2017
Merged

amp config #1619

merged 5 commits into from
Aug 3, 2017

Conversation

subfuzion
Copy link
Contributor

@subfuzion subfuzion commented Aug 3, 2017

Closes #1613

This PR adds cli and api support for docker swarm configs. The PR also includes a config example.

Verification

$ echo "foo=bar" | amp config create myconfig -
$ amp config ls
# confirm myconfig is displayed in the list
$ docker service create --name configdemo --config myconfig alpine sleep 1000000
$ docker exec $(docker ps --filter name=configdemo -q) cat /myconfig
# foo=bar

$ docker service rm configdemo
$ amp config rm myconfig

@subfuzion subfuzion changed the title [WIP] amp config amp config Aug 3, 2017
Copy link
Contributor

@bquenin bquenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@subfuzion subfuzion merged commit e4d7471 into master Aug 3, 2017
@subfuzion subfuzion deleted the amp-config branch August 3, 2017 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants