Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove telemetry from CE backend #39362

Open
wants to merge 1 commit into
base: release
Choose a base branch
from

Conversation

subhrashisdas
Copy link
Member

@subhrashisdas subhrashisdas commented Feb 19, 2025

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13428493738
Commit: 6476754
Cypress dashboard.
Tags: @tag.Sanity
Spec:


Thu, 20 Feb 2025 06:01:59 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Chores
    • Removed telemetry tracing functionality and its associated observability configurations to streamline the application.
    • Eliminated related code dependencies previously used for monitoring performance and capturing HTTP instrumentation.

Copy link
Contributor

coderabbitai bot commented Feb 19, 2025

Walkthrough

This PR removes the code related to OpenTelemetry tracing and observability. The file instrumentation.ts, which contained the tracing setup, has been deleted. In addition, its import was removed from server.ts, and several observability-related properties have been eliminated from the application configuration. These changes reflect a shift away from embedded telemetry features.

Changes

File(s) Change Summary
app/client/.../rts/src/instrumentation.ts
app/client/.../rts/src/server.ts
Removed the instrumentation file and its import, eliminating OpenTelemetry tracing and related HTTP instrumentation.
app/server/.../application.properties Removed multiple observability configurations including Prometheus, tracing, and Micrometer properties.

Possibly related PRs

Suggested labels

Bug

Suggested reviewers

  • sharat87
  • nidhi-nair
  • ApekshaBhosale

Poem

Code cleansed, the traces fade away,
Instrumentation gone, a simpler way.
Configs and metrics bid a fond adieu,
Leaving a leaner path in view.
Celebrate the clarity in the code's embrace,
A fresh start shines through every space!
🚀 Happy coding!


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1029152 and 6476754.

📒 Files selected for processing (3)
  • app/client/packages/rts/src/instrumentation.ts (0 hunks)
  • app/client/packages/rts/src/server.ts (0 hunks)
  • app/server/appsmith-server/src/main/resources/application.properties (0 hunks)
💤 Files with no reviewable changes (3)
  • app/client/packages/rts/src/server.ts
  • app/client/packages/rts/src/instrumentation.ts
  • app/server/appsmith-server/src/main/resources/application.properties
⏰ Context from checks skipped due to timeout of 90000ms (9)
  • GitHub Check: perform-test / rts-build / build
  • GitHub Check: perform-test / client-build / client-build
  • GitHub Check: perform-test / server-build / server-unit-tests
  • GitHub Check: client-unit-tests / client-unit-tests
  • GitHub Check: client-build / client-build
  • GitHub Check: server-unit-tests / server-unit-tests
  • GitHub Check: server-spotless / spotless-check
  • GitHub Check: client-lint / client-lint
  • GitHub Check: client-prettier / prettier-check

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Feb 19, 2025
@subhrashisdas subhrashisdas added Enhancement New feature or request ok-to-test Required label for CI and removed Enhancement New feature or request ok-to-test Required label for CI labels Feb 19, 2025
@github-actions github-actions bot removed the Enhancement New feature or request label Feb 19, 2025
@subhrashisdas subhrashisdas self-assigned this Feb 19, 2025
@subhrashisdas
Copy link
Member Author

/build-deploy-preview

Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/13410608166.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 39362.
recreate: .

Copy link

Deploy-Preview-URL: https://ce-39362.dp.appsmith.com

@subhrashisdas subhrashisdas force-pushed the feature/remove-telemetry branch from 1029152 to 6476754 Compare February 20, 2025 05:22
Copy link

Failed server tests

  • com.appsmith.server.git.ServerSchemaMigrationEnforcerTest#saveGitRepo_ImportAndThenExport_diffOccurs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants