Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(image): disable AVD-DS-0007 for history scanning #8366

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

nikpivkin
Copy link
Contributor

Description

The AVD-DS-0007 check should only be applied to the final layer. This PR removes the recently added export of the etrypoint instruction to the Dockerfile and fixes a bug with exporting metadata instructions.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nikpivkin
Copy link
Contributor Author

@simar7 Should we just disable the AVD-DS-0007 check when analyzing the image history like we did for #7368 ? Right now we have only one check that analyzes the entrypoint instruction but we may add more in the future.

@candrews
Copy link
Contributor

Should we just disable the AVD-DS-0007 check when analyzing the image history like we did for #7368 ?

I think that's a great idea! 👍

@simar7
Copy link
Member

simar7 commented Feb 18, 2025

@simar7 Should we just disable the AVD-DS-0007 check when analyzing the image history like we did for #7368 ? Right now we have only one check that analyzes the entrypoint instruction but we may add more in the future.

Yeah sounds good to me.

@nikpivkin nikpivkin changed the title fix(image): do not export entrypoint to Dockerfile fix(image): disable AVD-DS-0016 for history scanning Feb 19, 2025
@nikpivkin nikpivkin marked this pull request as ready for review February 19, 2025 09:35
Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nikpivkin update PR title, please (change AVD-DS-0016 to AVD-DS-0007)

@nikpivkin nikpivkin changed the title fix(image): disable AVD-DS-0016 for history scanning fix(image): disable AVD-DS-0007 for history scanning Feb 19, 2025
@nikpivkin
Copy link
Contributor Author

@DmitriyLewen Good catch. I have also updated the commit message.

@nikpivkin nikpivkin requested a review from simar7 February 21, 2025 06:34
@simar7 simar7 added this pull request to the merge queue Feb 21, 2025
Merged via the queue into aquasecurity:main with commit a3cd693 Feb 21, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(checks): Only One Entrypoint false negative
4 participants