Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(server): replace mock driver with memory cache in server tests #8416

Merged
merged 1 commit into from
Feb 18, 2025
Merged

test(server): replace mock driver with memory cache in server tests #8416

merged 1 commit into from
Feb 18, 2025

Conversation

knqyf263
Copy link
Collaborator

@knqyf263 knqyf263 commented Feb 18, 2025 •
edited
Loading

Overview

This PR replaces the mock driver with a memory cache in the server tests to improve test reliability and maintainability. The changes include removing mock files and updating test cases to use real local scanner implementation.

Description

  • Remove mock_driver.go and mock_driver_types.go files
  • Update server_test.go to use memory cache and local scanner
  • Modify test cases to work with the new scanning approach
  • Use real local scanner implementation instead of mocks
  • Update test fixtures to match the new testing approach

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@knqyf263
test: remove mock driver and update server test to use memory cache
04b114a 
This commit removes the mock driver files and updates the server test to use a memory cache and real local scanner. The changes include:
- Deleting `mock_driver.go` and `mock_driver_types.go`
- Updating `server_test.go` to use a memory cache and local scanner
- Modifying test cases to work with the new scanning approach
@knqyf263 knqyf263 self-assigned this Feb 18, 2025
@knqyf263 knqyf263 marked this pull request as ready for review February 18, 2025 06:48
DmitriyLewen
DmitriyLewen reviewed Feb 18, 2025
View reviewed changes
Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

IIUC this is last mock file.
So we remove mock from mage

@knqyf263
Copy link
Collaborator Author

Yes, I already have another branch to delete mockery since I was unsure which PR would be the last. I'll open another PR.

@DmitriyLewen DmitriyLewen added this pull request to the merge queue Feb 18, 2025
Merged via the queue into aquasecurity:main with commit e9b3f0b Feb 18, 2025
13 checks passed
@knqyf263 knqyf263 deleted the delete_driver_mock branch February 18, 2025 09:45
@knqyf263 knqyf263 mentioned this pull request Feb 18, 2025
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmitriyLewen DmitriyLewen DmitriyLewen approved these changes

Assignees

@knqyf263 knqyf263

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knqyf263 @DmitriyLewen