fix(appset): generated app errors should use the default requeue (#21887) #21936
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rumstead <[email protected]>
❗ Preview Environment deployment failed on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Signed-off-by: rumstead <[email protected]>
Signed-off-by: rumstead <[email protected]>
rumstead
commented
Feb 21, 2025
| @@ -164,7 +164,8 @@ func (r *ApplicationSetReconciler) Reconcile(ctx context.Context, req ctrl.Reque | |||
| Status: argov1alpha1.ApplicationSetConditionStatusTrue, | |||
| }, parametersGenerated, | |||
| ) | |||
| return ctrl.Result{RequeueAfter: ReconcileRequeueOnValidationError}, err | |||
| // In order for the controller SDK to respect RequeueAfter, the error must be nil | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
// If the returned error is non-nil, the Result is ignored and the request will be
// requeued using exponential backoff. The only exception is if the error is a
// TerminalError in which case no requeuing happens.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #21936 +/- ##
==========================================
- Coverage 55.63% 53.44% -2.20%
==========================================
Files 341 341
Lines 56996 56998 +2
==========================================
- Hits 31708 30460 -1248
- Misses 22634 23943 +1309
+ Partials 2654 2595 -59 ☔ View full report in Codecov by Sentry. |
zachaller
reviewed
Feb 21, 2025
gdsoumya
approved these changes
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21887
I think we should cherry pick this into 2.14, 2.13, and 2.12
Checklist: