Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas Optimizations #1135

Open
code423n4 opened this issue Apr 13, 2023 · 5 comments
Open

Gas Optimizations #1135

code423n4 opened this issue Apr 13, 2023 · 5 comments
Labels
bug Something isn't working edited-by-warden G (Gas Optimization) G-05 grade-a high quality report This report is of especially high quality selected for report This submission will be included/highlighted in the audit report sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons

Comments

@code423n4
Copy link
Contributor

See the markdown file with the details of this report here.
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Apr 13, 2023
code423n4 added a commit that referenced this issue Apr 13, 2023
@code423n4
JCN issue #1135
3c61656
code423n4 added a commit that referenced this issue Apr 13, 2023
@code423n4
JCN data for issue #1135
72ed2b9
code423n4 added a commit that referenced this issue Apr 13, 2023
@code423n4
Report for issue #1135 updated by JCN
8159c83
@c4-pre-sort c4-pre-sort added the high quality report This report is of especially high quality label May 3, 2023
@c4-pre-sort
Copy link

0xSorryNotSorry marked the issue as high quality report

@c4-sponsor
Copy link

daoio marked the issue as sponsor acknowledged

@c4-sponsor c4-sponsor added the sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons label May 15, 2023
@c4-judge
Copy link
Contributor

c4-judge commented Jun 9, 2023

HickupHH3 marked the issue as grade-a

@HickupHH3
Copy link

Best report for having benchmarked with the setup.

For issue #2, a lot of wardens pointed out replacing the boolean locked to a uint one. As it's an upgrade from V1 to V2, it can only be changed uint8 to preserve the storage layout. Furthermore, I tested it out and found that oddly, gas costs increased.

@c4-judge
Copy link
Contributor

HickupHH3 marked the issue as selected for report

@c4-judge c4-judge added the selected for report This submission will be included/highlighted in the audit report label Jun 10, 2023
@C4-Staff C4-Staff added the G-05 label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working edited-by-warden G (Gas Optimization) G-05 grade-a high quality report This report is of especially high quality selected for report This submission will be included/highlighted in the audit report sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@code423n4 @HickupHH3 @c4-judge @c4-sponsor @c4-pre-sort @C4-Staff