Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gas Optimizations #1264

Open
code423n4 opened this issue Apr 13, 2023 · 4 comments
Open

Gas Optimizations #1264

code423n4 opened this issue Apr 13, 2023 · 4 comments
Labels

Comments

@code423n4
Copy link
Contributor

See the markdown file with the details of this report here.

@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Apr 13, 2023
code423n4 added a commit that referenced this issue Apr 13, 2023
code423n4 added a commit that referenced this issue Apr 13, 2023
@c4-judge
Copy link
Contributor

HickupHH3 marked the issue as grade-b

@c3phas
Copy link

c3phas commented Jun 12, 2023

Hi @HickupHH3 , Would you kindly help me understand how this was graded, Comparing with other grade As and even the one selected for report, I may be having more issues/saving more gas. That being said, I am aware that a report being "better" is extremely subjective, and will respect your final decision as a judge. Thanks!

@HickupHH3
Copy link

Re-looked, can be bumped up to grade A.

I initially did it Alex's style, awarding gas per finding, then tallying the amount saved. However, given the number of gas opt reports I need to look through, this approach is very time and effort consuming.

In general, my criteria is:

  • no. of findings (automated vs manual)
  • detail and effort put in: even if automated, does the warden put in the effort to exclude false positives, or go into further detail into the findings made
  • benchmarking: if you see the best report selected, the gas savings achieved was rather crystal clear: it wasn't the generic (2.k gas saved per instance * 4) mentions, the warden put in the effort to run against the test suite

@c4-judge
Copy link
Contributor

HickupHH3 marked the issue as grade-a

@c4-judge c4-judge added grade-a and removed grade-b labels Jun 13, 2023
@C4-Staff C4-Staff added the G-03 label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants