Gas Optimizations

[code423n4]

See the markdown file with the details of this report here.

[HickupHH3]

Highly recommend categorizing by issue instead of per contract, easier to judge.

Formatting can be better.

Satisfactory because:

• Made the major gas saving findings (variable immutability, avoiding multiple SLOADs)
• Has a few unique recommendations:
  • The contract has lots of code from previous version that are being used in the latest version. While the storage variable may be needed in order to not break the storage layout, all the associated functionality in code can be removed in order to save deployment gas costs.
  • condition _underlying != address(0) has been already checked by the caller to the _bathify function.
  • batchOffer and batchRequote functions should call the offer internally to execute a jump instead of a function call

[c4-judge]

HickupHH3 marked the issue as grade-b