Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PENDING DEPENDENT] Test framework, part II #3890

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

apostasie
Copy link
Contributor

@apostasie apostasie commented Feb 16, 2025

This is on top of #3889 (on top of #3591) - should be merged in order.

This specific PR does cleanup and reorganize the testutil/test package.

Although this PR looks "large", it is not functionally changing anything (and is only touching tests and testing tools anyhow).

The key take-aways here are:

  • move the new test module to its final destination (mod/tigron)
  • split overcrowded module into more intuitive sub-packages:
    • expect (expect.Contains, expect.Match, expect.ExitCode)
    • require (require.Arm64, etc)
    • test (test.Case, etc)
  • renamed some methods to more intuitive names (eg: test.Require becomes require.All)

A tigron is a tigon in french :) (the offspring of a tiger and a lion)

The next PR will focus on linting code with more stringent standards.

@apostasie apostasie force-pushed the sub-project-testing-2 branch 3 times, most recently from 7363284 to 2f941a6 Compare February 21, 2025 23:05
@apostasie apostasie changed the title [WIP] Test framework, part II Test framework, part II Feb 22, 2025
@apostasie apostasie marked this pull request as ready for review February 22, 2025 00:25
@apostasie apostasie marked this pull request as draft February 22, 2025 04:47
@apostasie apostasie force-pushed the sub-project-testing-2 branch from 2f941a6 to 472a2b0 Compare February 22, 2025 20:00
@apostasie apostasie changed the title Test framework, part II [PENDING DEPENDENT] Test framework, part II Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant