add support syncfs to fix broken image #3891
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ningmingxiao <[email protected]>
ningmingxiao
force-pushed
the
add_sync_fs
branch
from
3b4918f to
b563cdc
Compare
ningmingxiao
changed the title
djdongjin
reviewed
Feb 17, 2025
There was a problem hiding this comment.
I think it's okay to add in nerdctl given it's also added in ctr.
But want to understand why we still need this given it was added in the diff plugin containerd/containerd#10284, e.g., which scenairo is not covered by setting this config in diff plugin?
| @@ -200,6 +200,7 @@ type ImagePullOptions struct { | |||
| // If nil, it will unpack automatically if only 1 platform is specified. | |||
| Unpack *bool | |||
| // Content for specific platforms. Empty if `--all-platforms` is true | |||
| SyncFs bool | |||
There was a problem hiding this comment.
please add some comments for SyncFs or move it to after OCISpecPlatform []v1.Platform. The comment above it is for OCISpecPlatform []v1.Platform
|
Why do you need this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sometimes image will broken after image is download then machine restart.
ref:containerd/containerd@11b7825