Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent acquire from blanking out hosts file #3912

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Prevent acquire from blanking out hosts file #3912

wants to merge 1 commit into from

Conversation

apostasie
Copy link
Contributor

Fix #3907

See comments for details.

ping @AkihiroSuda

@apostasie apostasie mentioned this pull request Feb 22, 2025
Open
@apostasie
Copy link
Contributor Author

apostasie commented Feb 22, 2025 •
edited
Loading

We should scrutinize this seriously.

I am not entirely convinced we are doing the right thing here wrt the content of the hosts file.

@apostasie apostasie marked this pull request as ready for review February 22, 2025 08:13
fahedouch
fahedouch approved these changes Feb 22, 2025
View reviewed changes
Copy link
Member

@fahedouch fahedouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@fahedouch fahedouch added this to the v2.x.x (tentative) milestone Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fahedouch fahedouch fahedouch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.x.x (tentative)
2 participants
@apostasie @fahedouch