-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distribution API seems missing #17726
Comments
What does docker return with this query? |
Docker API is described here: https://docs.docker.com/engine/api/v1.42/#tag/Distribution |
@Luap99 Could you implement this? |
I don't have much time, I need to work on the network stuff. |
Kindly to ask if there is somebody working for this issue? If not, I'm glad to undertake it. |
Thanks @rxda, I assigned it to you |
Podman doesn't support the distribution API. This is used when querying to see if a docker image is up-to-date. Instead of crashing this treats the stale image as good enough. See Also: containers/podman#17726 Fixes: aws#5019
A friendly reminder that this issue had no activity for 30 days. |
…5020) * fix: Favor a stale image when daemon doesn't support registry query Podman doesn't support the distribution API. This is used when querying to see if a docker image is up-to-date. Instead of crashing this treats the stale image as good enough. See Also: containers/podman#17726 Fixes: #5019 * Favor updating image when docker daemon is unable to check version * Update error message when docker cannot check image version
…ws#5020) * fix: Favor a stale image when daemon doesn't support registry query Podman doesn't support the distribution API. This is used when querying to see if a docker image is up-to-date. Instead of crashing this treats the stale image as good enough. See Also: containers/podman#17726 Fixes: aws#5019 * Favor updating image when docker daemon is unable to check version * Update error message when docker cannot check image version
@rxda did you ever get a chance to work on this? |
Is anyone currently addressing this issue? If not, I would be glad to take it on. |
Since we never heard back from @rxda, you got it. |
I'm so sorry, I have some trouble in my life this year, so I didn't have time to finish the work. I did some basic work, hope it helps |
Can I work on this issue? |
yes |
Yes, I don't think @jackgris was able to work on it. |
Yes, I'm sorry. Right after I requested this issue, I started having too much work at my job. I have time for it now, but if @pratt-snap wants to work on it, I'm fine with that. |
I've been working on this issue recently and have passed the basic functionality tests. If @pratt-snap is okay, I'd like to take it over, clean up my changes, and submit a PR. |
@kanlac Thanks, I assigned it to you |
Signed-off-by: Kan Cheung <[email protected]>
Issue Description
DockerApi 1.41 describes a distribution api path to query image data. This seems to be missing int he current podman socket api implementation
Steps to reproduce the issue
podman system service --time=0 unix:///tmp/podman.sock
curl -v --unix-socket /tmp/podman.sock -X POST http://localhost/v1.41/distribution/docker.io/library/postgres:latest/json
Describe the results you received
Describe the results you expected
The json containing the data
podman info output
Podman in a container
No
Privileged Or Rootless
Rootless
Upstream Latest Release
No
Additional environment details
Additional environment details
Additional information
Additional information like issue happens only occasionally or issue happens with a particular architecture or on a particular setting
The text was updated successfully, but these errors were encountered: