Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wire up --retry-delay for artifact pull #25352

Merged
merged 1 commit into from
Feb 19, 2025
Merged

wire up --retry-delay for artifact pull #25352

merged 1 commit into from
Feb 19, 2025
+14 −23

Conversation

baude
Copy link
Member

@baude baude commented Feb 18, 2025 •
edited
Loading

fixed a bug in the artifact code where --retry-delay was being discarded.

Fixes: https://issues.redhat.com/browse/RUN-2511

Does this PR introduce a user-facing change?

Fixed bug in `podman artifact pull` where the `--retry-delay` value was discarded.

@openshift-ci openshift-ci bot added release-note approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 18, 2025
@baude
Copy link
Member Author

baude commented Feb 18, 2025

/cherry-pick v5.4

@openshift-cherrypick-robot
Copy link
Collaborator

@baude: once the present PR merges, I will cherry-pick it on top of v5.4 in a new PR and assign it to you.

In response to this:

/cherry-pick v5.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rhatdan
Copy link
Member

rhatdan commented Feb 18, 2025

LGTM

@baude baude marked this pull request as draft February 18, 2025 16:09
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 18, 2025
@baude baude force-pushed the artifactpullretrydelay branch from 7ca7188 to 7f161e1 Compare February 18, 2025 16:15
@baude baude marked this pull request as ready for review February 18, 2025 18:25
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 18, 2025
Luap99
Luap99 reviewed Feb 19, 2025
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please just stick to Fixes: xxx in your commit message
https://github.com/containers/podman/blob/main/CONTRIBUTING.md#describe-your-changes-in-commit-messages

And I personally rather have everyone put in the full URL, first of all how would an outsider know where to find that jira card and second why make me do extra work to open the card

change itself looks fine

@Luap99 Luap99 mentioned this pull request Feb 19, 2025
Merged
@mheon
Copy link
Member

mheon commented Feb 19, 2025

LGTM on my end, though I'll defer merge until the commit message nits are addressed

@baude
wire up --retry-delay for artifact pull
6ad2dc0 
fixed a bug in the artifact code where --retry-delay was being
discarded.

Fixes: https://issues.redhat.com/browse/RUN-2511

Signed-off-by: Brent Baude <[email protected]>
@baude baude force-pushed the artifactpullretrydelay branch from 7f161e1 to 6ad2dc0 Compare February 19, 2025 15:11
Luap99
Luap99 approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 080a239 into containers:main Feb 19, 2025
82 checks passed
@openshift-cherrypick-robot
Copy link
Collaborator

@baude: new pull request created: #25364

In response to this:

/cherry-pick v5.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 19, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luap99 Luap99 Luap99 approved these changes

Assignees

@Luap99 Luap99

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@baude @openshift-cherrypick-robot @rhatdan @mheon @Luap99