Reliably trigger VSCode extension rebuild #4162
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for continuedev canceled.
|
The code to trigger a rebuild on missing extension.js added in continuedev#3276 turns out not to be entirely reliable because esbuild sometimes falls back to full-contents comparison rather than using the modtime. To fix this, include a buildTimestamp file in the input, and rewrite that when we want to trigger a rebuild.
owtaylor
force-pushed
the
trigger-esbuild-with-file
branch
from
54832d2 to
6475f8d
Compare
sestinj
previously approved these changes
Feb 15, 2025
sestinj
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The code to trigger a rebuild on missing extension.js added in #3276
turns out not to be entirely reliable because esbuild sometimes falls back to full-contents comparison rather than using the modtime. To fix this, include a buildTimestamp file in the input, and rewrite that when we want to trigger a rebuild.
Testing instructions
What this fixes is that when you launching the extension debug mode from vscode (after the first time), sometimes
vscode-extension:esbuild-notifyjust spins and spins andout/extension.jsis never written.cc: @halfline