-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QE: bump mapt to 0.7.4 #4617
base: main
Are you sure you want to change the base?
QE: bump mapt to 0.7.4 #4617
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rohanKanojia The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@albfan: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@@ -107,7 +107,7 @@ jobs: | |||
-e ARM_CLIENT_SECRET='${{secrets.ARM_CLIENT_SECRET}}' \ | |||
-e AZURE_STORAGE_ACCOUNT='${{ secrets.AZURE_STORAGE_ACCOUNT }}' \ | |||
-e AZURE_STORAGE_KEY='${{ secrets.AZURE_STORAGE_KEY }}' \ | |||
quay.io/redhat-developer/mapt:v0.6.9 azure \ | |||
quay.io/redhat-developer/mapt:v0.7.4 azure \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the newer version we need to adjust the params involved:
https://github.com/redhat-developer/mapt/blob/main/docs/azure/windows.md
At least now we need also the --nested-virt
+ I would suggest to add also --memory
and --cpus
as with those params the search for spot instances is not limited to the default vmsize but to any size matching the requirements
Use last available version from mapt
Relates: #4609