Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QE: bump mapt to 0.7.4 #4617

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

QE: bump mapt to 0.7.4 #4617

wants to merge 1 commit into from

Conversation

albfan
Copy link
Contributor

@albfan albfan commented Feb 13, 2025

Use last available version from mapt

Relates: #4609

@albfan albfan requested a review from adrianriobo February 13, 2025 11:30
@albfan albfan removed the request for review from evidolob February 13, 2025 11:30
Copy link

openshift-ci bot commented Feb 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rohanKanojia
Once this PR has been reviewed and has the lgtm label, please assign gbraad for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Feb 13, 2025

@albfan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-crc fba57b7 link true /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@@ -107,7 +107,7 @@ jobs:
-e ARM_CLIENT_SECRET='${{secrets.ARM_CLIENT_SECRET}}' \
-e AZURE_STORAGE_ACCOUNT='${{ secrets.AZURE_STORAGE_ACCOUNT }}' \
-e AZURE_STORAGE_KEY='${{ secrets.AZURE_STORAGE_KEY }}' \
quay.io/redhat-developer/mapt:v0.6.9 azure \
quay.io/redhat-developer/mapt:v0.7.4 azure \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the newer version we need to adjust the params involved:

https://github.com/redhat-developer/mapt/blob/main/docs/azure/windows.md

At least now we need also the --nested-virt + I would suggest to add also --memory and --cpus as with those params the search for spot instances is not limited to the default vmsize but to any size matching the requirements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants