remove enabling of file sharing and creation of smbshare from MSI #4620
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
this will be moved to the 'crc setup' command as we should only enable file sharing and create the smb share for home dir when users have set the config option 'enable-shared-dirs' to 'true' this should remove at least of the warnings reported by virustotal for the MSI: https://www.virustotal.com/gui/file/31b402dcc1da24265074a21a26018d6cde8eef0b63c77a18f89eb079b6556790
this label will be used to filter out preflight checks that should only run when 'enable-shared-dir' settings is set to 'true'
anjannath
force-pushed
the
issue_4619
branch
from
0f3f5a2 to
314dbd8
Compare
anjannath
changed the title
… windows earlier these were part of the MSI since we want to enable this only when user has set 'enable-shared-dirs' setting, this is moved to the preflight package where we can check this config value before hand this should remove at least of the warnings reported by virustotal for the MSI https://www.virustotal.com/gui/file/31b402dcc1da24265074a21a26018d6cde8eef0b63c77a18f89eb079b6556790
anjannath
force-pushed
the
issue_4619
branch
from
314dbd8 to
aac3023
Compare
anjannath
changed the title
|
@anjannath: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@anjannath didn't we have this as part of preflight before and then moved it to MSI? if yes then we might to revert those commits instead of this? |
no, i also thought the same and i did check the logs before creating the PR, seems this was never added as preflight checks, i think because when we added this SMB sharing support we were already moving every privileged operation on windows already to MSI so when we added support for SMB directory sharing this was only added to the MSI.. |
fixes #4619