-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QE] Set env var windows #4624
base: main
Are you sure you want to change the base?
[QE] Set env var windows #4624
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
9222f56
to
561d278
Compare
test/extended/crc/cmd/cmd.go
Outdated
switch value { | ||
case "true": | ||
value = "$true" | ||
break | ||
case "false": | ||
value = "$false" | ||
break | ||
default: | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we can replace this switch statement like this?
switch value { | |
case "true": | |
value = "$true" | |
break | |
case "false": | |
value = "$false" | |
break | |
default: | |
} | |
value = fmt.Sprintf("$%s", value) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe the function should be called SetBoolEnvVariable
then, because we want to append the $
only in case of bool values
561d278
to
f101751
Compare
@albfan: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
disableNTP: true, | ||
command: "start -b bundle", | ||
disableNTP: true, | ||
updateCheck: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please add some details to the commit log why this is needed now or what this fixes
Description
CI sets some configurations using env var,
FOO=bar
, but windows do not support that format, it should be$env:FOO=bar;
Fixes: #4618