Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QE] Set env var windows #4624

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

albfan
Copy link
Contributor

@albfan albfan commented Feb 17, 2025

Description

CI sets some configurations using env var, FOO=bar, but windows do not support that format, it should be $env:FOO=bar;

Fixes: #4618

@openshift-ci openshift-ci bot requested review from adrianriobo and gbraad February 17, 2025 12:51
Copy link

openshift-ci bot commented Feb 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign adrianriobo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@albfan albfan requested a review from anjannath February 17, 2025 12:53
@albfan albfan force-pushed the set-env-var-windows branch from 9222f56 to 561d278 Compare February 17, 2025 14:07
Comment on lines 106 to 114
switch value {
case "true":
value = "$true"
break
case "false":
value = "$false"
break
default:
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we can replace this switch statement like this?

Suggested change
switch value {
case "true":
value = "$true"
break
case "false":
value = "$false"
break
default:
}
value = fmt.Sprintf("$%s", value)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe the function should be called SetBoolEnvVariable then, because we want to append the $ only in case of bool values

@albfan albfan force-pushed the set-env-var-windows branch from 561d278 to f101751 Compare February 17, 2025 14:26
Copy link

openshift-ci bot commented Feb 17, 2025

@albfan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/integration-crc f101751 link true /test integration-crc
ci/prow/e2e-crc f101751 link true /test e2e-crc
ci/prow/images f101751 link true /test images
ci/prow/security f101751 link false /test security
ci/prow/e2e-microshift-crc f101751 link true /test e2e-microshift-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

disableNTP: true,
command: "start -b bundle",
disableNTP: true,
updateCheck: false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please add some details to the commit log why this is needed now or what this fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QE] integration: Setting env var on windows fail
3 participants