Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test (machine) : add some unit tests for growing lvm size based on persistent-volume-size config option in microshift preset #4628

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rohanKanojia
Copy link
Contributor

@rohanKanojia rohanKanojia commented Feb 18, 2025

Description

Add some unit tests for method growLVForMicroshift

Relates to: #4186, PR #4623

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Proposed changes

  • Replace *crcssh.Runner growLVForMicroshift method argument to receive an interface instead
  • Add unit tests using mocked implementation of ssh runner to verify various combinations of persistent-volume-size and size growth performed by the method

Testing

I've only verified that build is passing.

Contribution Checklist

  • I Keep It Small and Simple: The smaller the PR is, the easier it is to review and have it merged
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Which platform have you tested the code changes on?
    • Linux
    • Windows
    • MacOS

Copy link

openshift-ci bot commented Feb 18, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Feb 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign anjannath for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rohanKanojia rohanKanojia force-pushed the pr/growLVForMicroshift-unit-tests branch from 1fbfdeb to 6e3ac93 Compare February 18, 2025 09:03
@rohanKanojia rohanKanojia marked this pull request as ready for review February 18, 2025 13:20
@rohanKanojia rohanKanojia force-pushed the pr/growLVForMicroshift-unit-tests branch from 6e3ac93 to 81af69c Compare February 18, 2025 13:30
+ Replace sshRunner argument in growLVForMicroshift with an interface
+ Add unit tests for abovementioned method with various combinations of persistent-volume size and disk size
+ Add unit test for validatePersistentVolumeSize

Signed-off-by: Rohan Kumar <[email protected]>
@rohanKanojia rohanKanojia force-pushed the pr/growLVForMicroshift-unit-tests branch from 81af69c to b762672 Compare February 18, 2025 14:49
Copy link

openshift-ci bot commented Feb 18, 2025

@rohanKanojia: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-crc b762672 link true /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant