Add JavaTimeModule #1065
Add JavaTimeModule #1065
Conversation
mcruzdev
force-pushed
the
issue-995
branch
2 times, most recently
from
853f868 to
0c1886f
Compare
|
Ping @mcruzdev were you still working on this? |
|
Hi @cicoyle to be sincerous no, but I would like to continue, do you think to get this one? |
|
I need to add tests and probably to upgrade the dependency version |
mcruzdev
force-pushed
the
issue-995
branch
4 times, most recently
from
c633534 to
d087fea
Compare
|
Hi @cicoyle, sorry for delay... I think this one solve the issue. I tested calling the |
Signed-off-by: Matheus Cruz <[email protected]>
|
@artursouza can you check this? I am not sure to have the full context to evaluate these changes.. but looking at the code it looks ok to me. Do we want to have that new dependency in the SDK? I am ok with it. |
There was a problem hiding this comment.
@mcruzdev thank you for your contribution, it looks really good!
| @@ -71,6 +74,8 @@ public static class MyObjectTestToSerialize implements Serializable { | |||
| @JsonDeserialize(using = OffsetDateTimeDeserializer.class) | |||
| private OffsetDateTime timeValue; | |||
|
|
|||
There was a problem hiding this comment.
Could we please add private similar to other fields.
Description
Please explain the changes you've made
Issue reference
#995
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: