Adding producer and consumer app examples for Spring Boot integration #1208
+2,047
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salaboy
force-pushed
the
1207-sb-examples
branch
from
c7a933a to
100d037
Compare
|
@artur-ciocanu @artursouza @cicoyle recommendations are more than welcome on these examples.. I will add a README.md to this, but I appreciate code reviews and suggestions to get this merged ASAP |
salaboy
force-pushed
the
1207-sb-examples
branch
from
265c708 to
695b93e
Compare
|
This PR depends on: #1192 for the actor runtime connections |
salaboy
force-pushed
the
1207-sb-examples
branch
2 times, most recently
from
42a423d to
abbdf7c
Compare
artursouza
reviewed
Feb 6, 2025
spring-boot-examples/consumer-app/src/main/java/io/dapr/springboot/examples/consumer/Order.java
Show resolved
Hide resolved
artursouza
reviewed
Feb 6, 2025
...onsumer-app/src/main/java/io/dapr/springboot/examples/consumer/SubscriberRestController.java
Outdated
Show resolved
Hide resolved
artursouza
reviewed
Feb 6, 2025
artursouza
reviewed
Feb 6, 2025
artursouza
reviewed
Feb 6, 2025
salaboy
force-pushed
the
1207-sb-examples
branch
7 times, most recently
from
2c47a2b to
c52312a
Compare
|
There was an error handling pipeline event f3c3e364-6449-4327-8949-b4bcc2287e1c. |
|
There was an error handling pipeline event e2ad4049-1f9c-43b5-9730-d9968016868d. |
|
There was an error handling pipeline event bfb343e8-cca5-46c1-932c-b2d0a739308e. |
salaboy
force-pushed
the
1207-sb-examples
branch
from
cbb58f3 to
555fa34
Compare
|
@artursouza I've updated the tutorial to use a local registry, so we don't need to create container images and push containers to the dapr registry. |
|
@artursouza this is ready for reviewing and merging.. I am not sure if there are more things to update on the release scripts.. can you please check? |
artur-ciocanu
previously approved these changes
Feb 12, 2025
There was a problem hiding this comment.
@salaboy great job! I have left comments, but those are mostly about formatting, I think it makes sense to add Checkstyle and fix all the issues. The POM files are also weirdly formatted, ideally it should use the same convention as in the other modules.
My biggest concern/question is around usage of DockerClient, to be honest I am not sure why it was required and if there is a way to have a simpler setup.
spring-boot-examples/consumer-app/src/test/resources/application.properties
Outdated
Show resolved
Hide resolved
...roducer-app/src/test/java/io/dapr/springboot/examples/producer/DaprTestContainersConfig.java
Outdated
Show resolved
Hide resolved
...roducer-app/src/test/java/io/dapr/springboot/examples/producer/DaprTestContainersConfig.java
Outdated
Show resolved
Hide resolved
...roducer-app/src/test/java/io/dapr/springboot/examples/producer/DaprTestContainersConfig.java
Outdated
Show resolved
Hide resolved
...roducer-app/src/test/java/io/dapr/springboot/examples/producer/DaprTestContainersConfig.java
Outdated
Show resolved
Hide resolved
...producer-app/src/test/java/io/dapr/springboot/examples/producer/TestProducerApplication.java
Outdated
Show resolved
Hide resolved
Signed-off-by: salaboy <[email protected]>
…ainers Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
…vide steps to create containers with spring boot Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]> Signed-off-by: salaboy <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]> Signed-off-by: salaboy <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]> Signed-off-by: salaboy <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]> Signed-off-by: salaboy <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]> Signed-off-by: salaboy <[email protected]>
…boot/examples/consumer/ConsumerAppTests.java Co-authored-by: Cassie Coyle <[email protected]> Signed-off-by: salaboy <[email protected]>
…boot/examples/producer/TestSubscriberRestController.java Co-authored-by: Cassie Coyle <[email protected]> Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
salaboy
force-pushed
the
1207-sb-examples
branch
from
f7bd111 to
1293bb7
Compare
|
@artursouza automation is added but it works locally, not in the pipeline.. not sure if the pipelines are slower or something like that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds two Spring Boot application examples as part of a new directory called
spring-boot-examplesto differentiate from the plain Java examples provided in this repo.This tests uses Testcontainers and the
dapr-springmodules.Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1207
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: