Upgrading spring boot version to 3.4.3 #1220
Conversation
Signed-off-by: salaboy <[email protected]>
salaboy
force-pushed
the
upgrade-sb-version
branch
from
67f4594 to
7b2c775
Compare
There was a problem hiding this comment.
@salaboy overall looks good, but please take a look at my comments. Also please make sure all the tests are 🟢.
| @@ -32,6 +32,10 @@ jobs: | |||
| spring-boot-version: 3.3.0 | |||
| spring-boot-display-version: 3.3.x | |||
| experimental: false | |||
There was a problem hiding this comment.
I this file shouldn't we remove the 3.2.x from the GitHub action since it is no longer supported.
There was a problem hiding this comment.
I think we should, but my main doubt is because there is people out there that are still using 3.2.x and if we do something that breaks that version we will need to come back and fix it later.. I rather have some tests failing early on..
| @@ -45,7 +45,7 @@ | |||
| <junit-bom.version>5.8.2</junit-bom.version> | |||
| <snakeyaml.version>2.0</snakeyaml.version> | |||
| <testcontainers.version>1.20.0</testcontainers.version> | |||
There was a problem hiding this comment.
Shouldn't we use 3.3.x here instead of the latest and greatest. It is better to have the previous supported version for all our code, instead of relying on the latest Spring Boot version.
There was a problem hiding this comment.
I thought about this too.. but the end of support for is 2025-06-30. That only gives us 3 months of support. I would rather start testing 3.4.x and get ready to move to 3.5.x when it is final. I think if we are wise enough, we will align with their release cadence..
|
@artursouza @cicoyle can you please retrigger the pipelines? the issue here is not related to the changes done in spring boot. |
|
I have retriggered the failing job |
Description
Upgrading Spring Boot version to keep aligned with supported OSS version: https://spring.io/projects/spring-boot#support
I think we are ok to remove 3.2.x from the validation pipeline.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1219
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: