imagepruning: temporarily disable event handling #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…til ansible updates
@sjenning you probably want to revert this and find the real wiring problem
… doesn't need the answer
Underlying gonum/graph assigns conflicting IDs to new nodes after node deletion. Thus two different nodes amy be assigned the same ID. This leads to panic when an edge is set between them. Temporarily disabling event handling until the package is fixed. This ensures that no new nodes will be added to the graph after the first node gets removed. Signed-off-by: Michal Minář <[email protected]>
deads2k
force-pushed
the
rebase-04-1.11beta2
branch
from
ed3cecd to
d206b32
Compare
That doesn't seem unreasonable. Are we retaining handles to node ids somewhere other than edges maintained by the graph? |
We take references to whole nodes and keep them until the end. I don't see how that should prevent us from connecting newly added nodes once a single node is deleted from the graph (which is modifiable and allows for node removals). |
|
There's a unit test you'll need to remove too. |
Yes, sorry about that. Here's updated commit: miminar@706c1b3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Underlying gonum/graph assigns conflicting IDs to new nodes after node
deletion. Thus two different nodes amy be assigned the same ID. This
leads to panic when an edge is set between them.
Temporarily disabling event handling until the package is fixed. This
ensures that no new nodes will be added to the graph after the first
node gets removed.