Fixes #1130 Application redeployment is getting failed on OpenShift v3.7.0 #1176
Conversation
|
SonarQube analysis reported 1 issue
Watch the comments in this conversation to review them. |
| @@ -50,7 +50,7 @@ public DeploymentOpenShiftConverter(PlatformMode mode, Long openshiftDeployTimeo | |||
| } | |||
|
|
|||
| @Override | |||
| public HasMetadata convert(HasMetadata item) { | |||
| public HasMetadata convert(HasMetadata item, boolean trimImageInContainerSpec) { | |||
There was a problem hiding this comment.
|
@rohanKanojia |
|
@mojsha : Yes, I think it's possible. Could you please file an issue for that and assign it to me? |
|
@rohanKanojia: Done #1177, but I could not assign it to you. |
There was a problem hiding this comment.
This looks good @rohanKanojia. But there is catch (may be wrong), we should call the setImage("") if its redeployment scenario. isnt it?
|
@hrishin : I think that during the build, we're don't know whether it's deployment scenario or redeployment scenario. Fabric8 maven plugin does a PUT of deployment config, so deploy or redeploy it's the same thing. Here we're just avoiding the update in container image spec, which was triggering redeployments. ImageTrigger would automatically inject the image into it. |
…enShift v3.7.0 + Added a workaround to deal with ImageTriggers. + Added flag fabric8.openshift.trimImageInContainerSpec which would trim image in container spec + Updated documentation related to flag.
rohanKanojia
force-pushed
the
issue1130
branch
from
b23cb09 to
fd9756f
Compare
|
@rohanKanojia @hrishin Did we run all required tests after this merge? |
…tainerSpec parameter to set image field empty This paramter was introduced in fabric8io#1176 which stops automatic redeployments in openshift by setting image field in DC empty. I skipped this parameter during refactoring but now since it's causing redeployments on Openshift even after setting fabric8.openshift.enableAutomatic=true; let's reintroduce this.
…tainerSpec parameter to set image field empty This paramter was introduced in fabric8io#1176 which stops automatic redeployments in openshift by setting image field in DC empty. I skipped this parameter during refactoring but now since it's causing redeployments on Openshift even after setting fabric8.openshift.enableAutomatic=true; let's reintroduce this.
…tainerSpec parameter to set image field empty This paramter was introduced in fabric8io#1176 which stops automatic redeployments in openshift by setting image field in DC empty. I skipped this parameter during refactoring but now since it's causing redeployments on Openshift even after setting fabric8.openshift.enableAutomatic=true; let's reintroduce this.
…c parameter to set image field empty (#1618) This paramter was introduced in #1176 which stops automatic redeployments in openshift by setting image field in DC empty. I skipped this parameter during refactoring but now since it's causing redeployments on Openshift even after setting fabric8.openshift.enableAutomatic=true; let's reintroduce this.
image in container spec
#1130