Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotator code for main model and extension model modules should be merged #3486

Closed
manusa opened this issue Sep 22, 2021 · 1 comment
Closed
Assignees
Milestone

Comments

@manusa
Copy link
Member

manusa commented Sep 22, 2021

Description

Currently there are 2 ways that generated model types get annotated (+further generated) depending on their parent module.

For regular/main model modules (those located in kubernetes-model-generator), the annotators defined in kubernetes-model-generator/kubernetes-model-jsonschema2pojo are used.

For extension model modules (those located in extensions), the annotator defined in model-annotator is used.

To prevent issues related to different code generation and for consistency reasons, both annotator modules should be merged and only one should be kept.

Relates to #3433

@stale
Copy link

stale bot commented Dec 21, 2021

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale label Dec 21, 2021
@stale stale bot removed the status/stale label Dec 21, 2021
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 23, 2022
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 23, 2022
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 23, 2022
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 23, 2022
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 24, 2022
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 24, 2022
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 25, 2022
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 25, 2022
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 25, 2022
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 25, 2022
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 25, 2022
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 25, 2022
@manusa manusa added this to the 6.0.0 milestone Jun 3, 2022
@manusa manusa closed this as completed in cf3b65d Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants