Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PortForwarding cleanups #4149

Closed
shawkins opened this issue May 15, 2022 · 0 comments · Fixed by #4150
Closed

PortForwarding cleanups #4149

shawkins opened this issue May 15, 2022 · 0 comments · Fixed by #4150
Assignees
@shawkins
Milestone
6.0.0

Comments

@shawkins
Copy link
Contributor

  • there's too many generic parameters
  • it's not documented that you can only use channels in blocking mode. If you pass in non-blocking you either get busy loops or possibly missing data
  • writes should not be done in the websocket thread just in case they are blocking
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 15, 2022
@shawkins
fix fabric8io#4149: several cleanups related to port forwarding
6543546
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 15, 2022
@shawkins
fix fabric8io#4149: several cleanups related to port forwarding
320aff0
@shawkins shawkins mentioned this issue May 15, 2022
Merged
11 tasks
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 15, 2022
@shawkins
fix fabric8io#4149: several cleanups related to port forwarding
e0174e8
@shawkins shawkins mentioned this issue May 16, 2022
Open
@manusa manusa added this to the 6.0.0 milestone May 18, 2022
manusa pushed a commit that referenced this issue May 18, 2022
@shawkins @manusa
fix #4149: several cleanups related to port forwarding
5e683d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawkins shawkins

Labels
None yet
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

fix #4149: several cleanups related to port forwarding shawkins/kubernetes-client
2 participants
@manusa @shawkins