-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lombok's EqualsAndHashCode
for CR should have callSuper=true
#4259
Comments
I completely missed this one 😓 , looks reasonable, @rohanKanojia let me know if have any trouble picking this up 👍 the relevant line of code is this: Line 27 in e28f569
|
rohanKanojia
added a commit
to rohanKanojia/kubernetes-client
that referenced
this issue
Jul 28, 2022
have `@EqualsAndHashCode(callSuper = true)` (fabric8io#4259) CustomResource classes generated in extra-annotations mode by Java generator should have `@EqualsAndHashCode` annotation configured with `callSuper = true` in case class extends another class. Signed-off-by: Rohan Kumar <[email protected]>
rohanKanojia
added a commit
to rohanKanojia/kubernetes-client
that referenced
this issue
Jul 28, 2022
have `@EqualsAndHashCode(callSuper = true)` (fabric8io#4259) CustomResource classes generated in extra-annotations mode by Java generator should have `@EqualsAndHashCode` annotation configured with `callSuper = true` in case class extends another class. Signed-off-by: Rohan Kumar <[email protected]>
11 tasks
rohanKanojia
added a commit
to rohanKanojia/kubernetes-client
that referenced
this issue
Jul 28, 2022
have `@EqualsAndHashCode(callSuper = true)` (fabric8io#4259) CustomResource classes generated in extra-annotations mode by Java generator should have `@EqualsAndHashCode` annotation configured with `callSuper = true` in case class extends another class. Signed-off-by: Rohan Kumar <[email protected]>
rohanKanojia
added a commit
to rohanKanojia/kubernetes-client
that referenced
this issue
Jul 28, 2022
have `@EqualsAndHashCode(callSuper = true)` (fabric8io#4259) CustomResource classes generated in extra-annotations mode by Java generator should have `@EqualsAndHashCode` annotation configured with `callSuper = true` in case class extends another class. Signed-off-by: Rohan Kumar <[email protected]>
manusa
pushed a commit
that referenced
this issue
Jul 29, 2022
have `@EqualsAndHashCode(callSuper = true)` (#4259) CustomResource classes generated in extra-annotations mode by Java generator should have `@EqualsAndHashCode` annotation configured with `callSuper = true` in case class extends another class. Signed-off-by: Rohan Kumar <[email protected]>
Repository owner
moved this from Review
to Done
in Eclipse JKube
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
CRD to Java generator with
Config#objectExtraAnnotations
set should generate@lombok.EqualsAndHashCode(callSuper = true)
for CR classes since generated class has no fields and spec is accessible viaCustomResource
superclass.Since it doesn't have
callSuper = true
lombok produces something like this:Fabric8 Kubernetes Client version
6.0.0-RC1
Steps to reproduce
kubectl get crd/middlewares.traefik.containo.us -o yaml > crd.yaml
)jbang io.fabric8:java-generator-cli:6.0.0-RC1 -t generated -s crd.yaml --add-extra-annotations
Expected behavior
Generated CR class to have
@lombok.EqualsAndHashCode(callSuper = true)
Runtime
other (please specify in additional context)
Kubernetes API Server version
other (please specify in additional context)
Environment
Linux
Fabric8 Kubernetes Client Logs
No response
Additional context
Kubelet version 1.23.6
Kubernetes flavor
k3s
v1.23.6+k3s1The text was updated successfully, but these errors were encountered: