Fix RELEASE_VERSION parameter dependency

[sbose78]

osio-pipeline/vars/processTemplate.groovy

Lines 32 to 46 in 8b8248e

	def applyDefaults(provided=[:], templateParams) {
	def params = [:]
	def setParam = { key, compute ->
	if (key in templateParams) {
	params[key] = provided[key] ?: compute()
	}
	}
	setParam('SUFFIX_NAME') { "-${env.BRANCH_NAME}".toLowerCase() }
	setParam('SOURCE_REPOSITORY_REF') { Utils.shWithOutput(this, "git rev-parse --short HEAD") }
	setParam('SOURCE_REPOSITORY_URL') { Utils.shWithOutput(this, "git config remote.origin.url") }
	setParam('RELEASE_VERSION') { Utils.shWithOutput(this, "git rev-list --count HEAD") }
	return params
	}

This method makes it mandatory for the openshift template to have the RELEASE_VERSION parameter else there's a failure because of non-availability of meta

osio-pipeline/vars/deploy.groovy

Lines 12 to 24 in 8b8248e

	def required = ['ImageStream', 'DeploymentConfig', 'meta']
	def res = Utils.mergeResources(args.resources)
	def found = res.keySet()
	def missing = required - found
	if (missing) {
	error "Missing mandatory build resources params: $missing; found: $found"
	}
	def tag = res.meta.tag
	if (!tag) {
	error "Missing mandatory metadata: tag"
	}

Is this intended or should we have something like :

// returns a map of parameter name: value by choosing from provided if the
// key is present in templateParams or uses default value
def applyDefaults(provided=[:], templateParams) {

  def params = [:]
  def setParam = { key, compute ->
    if (key in templateParams) {
      params[key] = provided[key] ?: compute()
    }
   else{
     params[key]  = compute()
   }  
  }

  setParam('SUFFIX_NAME') { "-${env.BRANCH_NAME}".toLowerCase() }
  setParam('SOURCE_REPOSITORY_REF') { Utils.shWithOutput(this, "git rev-parse --short HEAD") }
  setParam('SOURCE_REPOSITORY_URL') { Utils.shWithOutput(this, "git config remote.origin.url") }
  setParam('RELEASE_VERSION') { Utils.shWithOutput(this, "git rev-list --count HEAD") }
  return params
}

[sbose78]

This would fail too if the param is absent.

+ oc process -f .openshiftio/application.yaml SUFFIX_NAME=-master SOURCE_REPOSITORY_REF=e61ed08 SOURCE_REPOSITORY_URL=https://github.com/sbose78/nodejs-rest-http-crud.git RELEASE_VERSION=140 -o yaml
unknown parameter name "RELEASE_VERSION"

[sbose78]

--ignore-unknown-parameters
openshift/origin#15230 should work though.

[hrishin]

If a user doesn't provide RELEASE_VERSION parameter then processtemplate generates default value for it.

osio-pipeline/vars/processTemplate.groovy

Line 44 in 8b8248e

setParam('RELEASE_VERSION') { Utils.shWithOutput(this, "git rev-list --count HEAD") }

For a user its optional parameter however for pipeline process its a madentory parameter.

Ideally, it should not casue any issue. Let us check it once why its failing.

Does that answers the issue @sbose78?

[sbose78]

@hrishin if the user doesn't provide it, but the param is present in the template, only then it works. If the param is absent in the template,it errors out. I've pointed out the code responsible for that :)

[sbose78]

A good number of boosters would need to be updated to work with this.
nodeshift-starters/nodejs-rest-http-crud#116

[hrishin]

Yes @sbose78. Thanks! for the PR. 👍

[pradeepto]

@hrishin Assuming that you are working on it and thus assigning it to you. Change if it is wrong.