Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixbug: #1100 #1105

Merged
merged 1 commit into from
Mar 26, 2024
Merged

fixbug: #1100 #1105

merged 1 commit into from
Mar 26, 2024

Conversation

iorisa
Copy link
Collaborator

@iorisa iorisa commented Mar 25, 2024

Features
fixbug: #1100

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 42.85714% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 81.39%. Comparing base (12948a5) to head (b403f2b).

Files Patch % Lines
metagpt/provider/google_gemini_api.py 42.85% 8 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1105      +/-   ##
==========================================
- Coverage   81.44%   81.39%   -0.05%     
==========================================
  Files         248      248              
  Lines       13885    13897      +12     
==========================================
+ Hits        11308    11312       +4     
- Misses       2577     2585       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@geekan geekan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://stackoverflow.com/questions/77723993/gemini-pro-api-blocking-replies Referring to this, is it possible to directly optimize the code?

@iorisa iorisa requested a review from geekan March 26, 2024 02:52
@geekan geekan merged commit 2cb7805 into geekan:main Mar 26, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants