Skip to content

Commit

Permalink
Merge pull request openshift#18518 from mrogers950/frontproxy-ca-name
Browse files Browse the repository at this point in the history
Automatic merge from submit-queue (batch tested with PRs 17866, 18518, 18554, 18534, 17759).

fix the front proxy CA name

frontproxy-ca.crt was being generated with the same name as the OpenShift signer CA.
@openshift/sig-security
  • Loading branch information
openshift-merge-robot authored Feb 12, 2018
2 parents c5bd51f + 4c3698b commit 3522daf
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
7 changes: 5 additions & 2 deletions pkg/cmd/server/admin/create_mastercerts.go
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,10 @@ func (o CreateMasterCertsOptions) CreateMasterCerts() error {
if err != nil {
return err
}
getFrontProxySignerCertOptions, err := o.createNewSigner(FrontProxyCAFilePrefix)

frontProxyOptions := o
frontProxyOptions.SignerName = DefaultFrontProxySignerName()
getFrontProxySignerCertOptions, err := frontProxyOptions.createNewSigner(FrontProxyCAFilePrefix)
if err != nil {
return err
}
Expand All @@ -197,7 +200,7 @@ func (o CreateMasterCertsOptions) CreateMasterCerts() error {
func() error { return o.createProxyClientCerts(getSignerCertOptions) },
func() error { return o.createServiceAccountKeys() },
func() error { return o.createServiceSigningCA(getSignerCertOptions) },
func() error { return o.createAggregatorClientCerts(getFrontProxySignerCertOptions) },
func() error { return frontProxyOptions.createAggregatorClientCerts(getFrontProxySignerCertOptions) },
)
return utilerrors.NewAggregate(errs)
}
Expand Down
4 changes: 4 additions & 0 deletions pkg/cmd/server/admin/default_certs.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@ func DefaultKubeletClientCerts(certDir string) []ClientCertInfo {
}
}

func DefaultFrontProxySignerName() string {
return fmt.Sprintf("%s@%d", "aggregator-proxy-ca", time.Now().Unix())
}

func DefaultMasterKubeletClientCertInfo(certDir string) ClientCertInfo {
return ClientCertInfo{
CertLocation: configapi.CertInfo{
Expand Down

0 comments on commit 3522daf

Please sign in to comment.